Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REGRESSION (265576@main): Wrong paint order of positioned and in-flow content inside overflow:scroll #17588

Closed
wants to merge 1 commit into from
Closed

REGRESSION (265576@main): Wrong paint order of positioned and in-flow content inside overflow:scroll #17588

wants to merge 1 commit into from

Conversation

anttijk
Copy link
Contributor

@anttijk anttijk commented Sep 8, 2023 •
edited by webkit-early-warning-system

fff1fa9

REGRESSION (265576@main): Wrong paint order of positioned and in-flow content inside overflow:scroll
https://bugs.webkit.org/show_bug.cgi?id=261302
rdar://115144982

Reviewed by NOBODY (OOPS!).

We end up having multiple backing store providers that overlap each other.

* LayoutTests/compositing/layer-creation/clipping-scope/nested-scroller-overlap-expected.txt:
* LayoutTests/compositing/shared-backing/overflow-scroll/backing-sharing-multiple-overlap-expected.txt: Added.
* LayoutTests/compositing/shared-backing/overflow-scroll/backing-sharing-multiple-overlap.html: Added.
* LayoutTests/platform/ios-wk2/compositing/layer-creation/clipping-scope/nested-scroller-overlap-expected.txt:
* LayoutTests/platform/ios-wk2/compositing/shared-backing/overflow-scroll/backing-sharing-multiple-overlap-expected.txt: Added.
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::BackingSharingState::canUseMultipleProviders const):

Move the overlap test to canUseMultipleProviders so it is done after descendant traversal for each new provider candidate.

(WebCore::RenderLayerCompositor::BackingSharingState::updateBeforeDescendantTraversal):

fff1fa9

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk anttijk self-assigned this Sep 8, 2023
@anttijk anttijk added the Layout and Rendering For bugs with layout and rendering of Web pages. label Sep 8, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash acd9819)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac   🛠 gtk
❌ 🧪 ios-wk2-wpt ❌ 🧪 mac-wk1 ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ⏳ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ⏳ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 8, 2023
@anttijk anttijk removed the merging-blocked Applied to prevent a change from being merged label Sep 8, 2023
@anttijk anttijk force-pushed the backing-sharing-multiple-overlap branch from acd9819 to 2dd59e6 Compare September 8, 2023 13:17
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 2dd59e6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2 ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim ✅ 🧪 mac-wk2-stress ⏳ 🧪 jsc-armv7-tests
✅ 🛠 watch
✅ 🛠 watch-sim

@anttijk
REGRESSION (265576@main): Wrong paint order of positioned and in-flow…
fff1fa9 
… content inside overflow:scroll

https://bugs.webkit.org/show_bug.cgi?id=261302
rdar://115144982

Reviewed by NOBODY (OOPS!).

We end up having multiple backing store providers that overlap each other.

* LayoutTests/compositing/layer-creation/clipping-scope/nested-scroller-overlap-expected.txt:
* LayoutTests/compositing/shared-backing/overflow-scroll/backing-sharing-multiple-overlap-expected.txt: Added.
* LayoutTests/compositing/shared-backing/overflow-scroll/backing-sharing-multiple-overlap.html: Added.
* LayoutTests/platform/ios-wk2/compositing/layer-creation/clipping-scope/nested-scroller-overlap-expected.txt:
* LayoutTests/platform/ios-wk2/compositing/shared-backing/overflow-scroll/backing-sharing-multiple-overlap-expected.txt: Added.
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::BackingSharingState::canUseMultipleProviders const):

Move the overlap test to canUseMultipleProviders so it is done after descendant traversal for each new provider candidate.

(WebCore::RenderLayerCompositor::BackingSharingState::updateBeforeDescendantTraversal):
@anttijk anttijk force-pushed the backing-sharing-multiple-overlap branch from 2dd59e6 to fff1fa9 Compare September 8, 2023 13:32
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash fff1fa9)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-wk2-stress
  🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@smfr smfr added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Sep 15, 2023
@smfr smfr self-requested a review September 15, 2023 01:25
@smfr
Copy link
Contributor

smfr commented Sep 15, 2023

Obsoleted by #17798

@smfr smfr closed this Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smfr smfr Awaiting requested review from smfr

Assignees

@anttijk anttijk

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
4 participants
@anttijk @webkit-early-warning-system @smfr @webkit-ews-buildbot