[WTF] Need specialization for DefaultHash<CompactPtr<StringImpl>> with StringHash #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
JavaScriptCore
hortont424
approved these changes
Jun 24, 2022
Constellation
force-pushed
the
eng/WTF-Need-specialization-for-DefaultHashCompactPtrStringImpl-with-StringHash
branch
from
4b819b6
to
fd5f3de
Compare
Constellation
added
the
merge-queue
…h StringHash https://bugs.webkit.org/show_bug.cgi?id=241955 Reviewed by Tim Horton. AtomStringTable uses CompactPtr only when it is more efficient than PackedPtr, which means, it is non-simulator iOS family. And we lack the specialization of DefaultHash<CompactPtr<StringImpl>> with StringHash: usually, we can just use PtrHash. But for StringImpl, we have specialization of this hash function, so we must make DefaultHash StringHash for CompactPtr<StringImpl> case too. This patch also adds a test including HashMap<CompactPtr<StringImpl>> removal & re-addition to hit deleted cases. * Source/WTF/wtf/text/StringHash.h: (WTF::StringHash::hash): (WTF::StringHash::equal): (WTF::ASCIICaseInsensitiveHash::hash): (WTF::ASCIICaseInsensitiveHash::equal): * Source/WTF/wtf/text/StringImpl.h: * Tools/TestWebKitAPI/Tests/WTF/CompactPtr.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/251824@main
webkit-early-warning-system
force-pushed
the
eng/WTF-Need-specialization-for-DefaultHashCompactPtrStringImpl-with-StringHash
branch
from
fd5f3de
to
62275c8
Compare
|
Committed 251824@main (62275c8): https://commits.webkit.org/251824@main Reviewed commits have been landed. Closing PR #1764 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Constellation
deleted the
eng/WTF-Need-specialization-for-DefaultHashCompactPtrStringImpl-with-StringHash
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
62275c8