Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block SYS_sigaltstack in sandboxes #17712

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Block SYS_sigaltstack in sandboxes #17712

merged 1 commit into from
Sep 13, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Sep 12, 2023 •
edited by webkit-early-warning-system
Loading

2826247

Block SYS_sigaltstack in sandboxes
https://bugs.webkit.org/show_bug.cgi?id=261481
rdar://114840732

Reviewed by Brent Fulgham.

Block SYS_sigaltstack in sandboxes when ASAN is not enabled.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/267951@main

416236d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@pvollan pvollan self-assigned this Sep 12, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Sep 12, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 12, 2023 •
edited
Loading

EWS run on current version of this PR (hash 416236d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

brentfulgham
brentfulgham approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too bad we don't have anENABLED(ASAN) macro! :-)
r=me

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label Sep 13, 2023
@pvollan
Copy link
Contributor Author

pvollan commented Sep 13, 2023

Too bad we don't have anENABLED(ASAN) macro! :-) r=me

Thanks for reviewing!

@webkit-commit-queue webkit-commit-queue force-pushed the eng/Block-SYS_sigaltstack-in-sandboxes branch from 416236d to 783d4f1 Compare September 13, 2023 14:54
@pvollan
Block SYS_sigaltstack in sandboxes
2826247 
https://bugs.webkit.org/show_bug.cgi?id=261481
rdar://114840732

Reviewed by Brent Fulgham.

Block SYS_sigaltstack in sandboxes when ASAN is not enabled.

* Source/WebKit/GPUProcess/mac/com.apple.WebKit.GPUProcess.sb.in:
* Source/WebKit/NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb.in:
* Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in:
* Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:

Canonical link: https://commits.webkit.org/267951@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Block-SYS_sigaltstack-in-sandboxes branch from 783d4f1 to 2826247 Compare September 13, 2023 14:57
@webkit-commit-queue
Copy link
Collaborator

Committed 267951@main (2826247): https://commits.webkit.org/267951@main

Reviewed commits have been landed. Closing PR #17712 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 2826247 into WebKit:main Sep 13, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentfulgham brentfulgham brentfulgham approved these changes

@ddkilzer ddkilzer Awaiting requested review from ddkilzer

@cdumez cdumez Awaiting requested review from cdumez

@szewai szewai Awaiting requested review from szewai

@gavin-apple gavin-apple Awaiting requested review from gavin-apple

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @brentfulgham