-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import webvtt/parsing WPT #17852
Import webvtt/parsing WPT #17852
Conversation
EWS run on previous version of this PR (hash 5c45cb5) |
LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/README.md
Show resolved
Hide resolved
@cola119 - Can you add 'hash' for the test similar to your other import commit in commit message / log? |
5c45cb5
to
3c81e57
Compare
EWS run on previous version of this PR (hash 3c81e57) |
This comment was marked as resolved.
This comment was marked as resolved.
3c81e57
to
ad30179
Compare
EWS run on previous version of this PR (hash ad30179) |
ad30179
to
445b1cc
Compare
EWS run on previous version of this PR (hash 445b1cc) |
445b1cc
to
c382dcb
Compare
EWS run on current version of this PR (hash c382dcb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is marvelous, thank you!
https://bugs.webkit.org/show_bug.cgi?id=261671 Reviewed by Eric Carlson. Upstream commit: web-platform-tests/wpt@46b2968 Thanks to the work done in https://bugs.webkit.org/show_bug.cgi?id=261460, we can run WPT for WebVTT in WebKitTestRunner. So we can import them from the upstream and remove the duplicate tests copied to /LayoutTests/media/track/opera/track/webvtt/parsing. Additionally, the WebKitTestRunner has been updated to fix flakiness that occurs when running tests in parallel. This is achieved by ensuring that the caption mode is set to testing mode before setting the caption display mode. * LayoutTests/imported/w3c/resources/import-expectations.json: * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/README.md: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/categories.json: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/buildtests.py: Added. (appendtest): * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/common.js: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/common.js. (prefix.in.namespaces.namespaces.hasOwnProperty): (format): (test_serializer): (print_diffs): (runTests.): (runTests): (trackError): (removeElm): * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/dat/entities.dat: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/dat/entities.dat. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/dat/tags.dat: Copied from LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/dat/tree-building.dat. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/dat/text.dat: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/dat/timestamps.dat: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/dat/timestamps.dat. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/dat/tree-building.dat: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/dat/tree-building.dat. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/dat/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/entities-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/entities.html: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/entities.html. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/tags-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/tags.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/text-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/text.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/timestamps-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/timestamps.html: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/timestamps.html. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/tree-building-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/tree-building.html: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/tree-building.html. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/tests/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/cue-text-parsing/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/README.md: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/categories.json: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/signature-invalid-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/signature-invalid.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/arrows.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/comment-in-cue-text.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/empty.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/header-garbage.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/header-space.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/header-tab.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/header-timings.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/ids.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/newlines.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/nulls.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/regions-id.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/regions-lines.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/regions-old.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/regions-regionanchor.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/regions-scroll.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/regions-viewportanchor.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/settings-align.test: Copied from LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-align.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/settings-line.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/settings-multiple.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/settings-position.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/settings-region.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/settings-size.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/settings-vertical.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-bom.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-formfeed.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-formfeed.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-invalid-whitespace.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-invalid.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-lowercase.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-lowercase.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-missing-whitespace.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-missing.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/no-signature.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-no-newline.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-null.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-null.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-partial.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-too-short.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-space-no-newline.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-space.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-tab-no-newline.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-tab.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-timings.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-two-boms.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-two-boms.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/signature-websrt.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-websrt.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/stylesheets.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/timings-60.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/timings-eof.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/timings-garbage.test: Copied from LayoutTests/media/track/opera/track/webvtt/parsing/support/timings-garbage.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/timings-negative.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/timings-omitted-hours.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/timings-too-long.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/timings-too-short.test: Copied from LayoutTests/media/track/opera/track/webvtt/parsing/support/timings-too-short.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/support/whitespace-chars.test: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/arrows-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/arrows.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/categories.json: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/comment-in-cue-text-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/comment-in-cue-text.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-garbage-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-garbage.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-regions-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-regions.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-space-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-space.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-tab-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-tab.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-timings-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/header-timings.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/ids-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/ids.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/newlines-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/newlines.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/nulls-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/nulls.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-edge-case-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-edge-case.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-id-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-id.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-lines-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-lines.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-old-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-old.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-regionanchor-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-regionanchor.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-scroll-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-scroll.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-viewportanchor-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/regions-viewportanchor.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-align-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-align.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-line-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-line.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-multiple-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-multiple.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-position-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-position.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-region-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-region.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-size-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-size.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-vertical-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/settings-vertical.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-bom-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-bom.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-no-newline-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-no-newline.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-space-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-space-no-newline-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-space-no-newline.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-space.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-tab-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-tab-no-newline-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-tab-no-newline.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-tab.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-timings-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/signature-timings.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/stylesheets-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/stylesheets.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/arrows.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/arrows.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/comment-in-cue-text.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/header-garbage.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/header-garbage.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/header-regions.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/header-space.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/header-space.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/header-tab.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/header-tab.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/header-timings.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/header-timings.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/ids.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/ids.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/newlines.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/nulls.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/nulls.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/regions-edge-case.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/regions-id.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/regions-lines.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/regions-old.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/regions-regionanchor.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/regions-scroll.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/regions-viewportanchor.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/settings-align.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-align.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/settings-line.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/settings-multiple.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/settings-position.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/settings-region.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/settings-size.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-size.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/settings-vertical.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-vertical.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/signature-bom.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-bom.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/signature-no-newline.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-no-newline.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/signature-space-no-newline.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-space-no-newline.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/signature-space.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-space.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/signature-tab-no-newline.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-tab-no-newline.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/signature-tab.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-tab.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/signature-timings.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/signature-timings.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/stylesheets.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/timings-60.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/timings-60.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/timings-eof.vtt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/timings-garbage.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/timings-garbage.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/timings-negative.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/timings-negative.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/timings-omitted-hours.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/omitted-hours.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/timings-too-long.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/timings-too-long.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/timings-too-short.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/timings-too-short.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/support/whitespace-chars.vtt: Renamed from LayoutTests/media/track/opera/track/webvtt/parsing/support/space-chars.vtt. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-60-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-60.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-eof-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-eof.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-garbage-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-garbage.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-negative-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-negative.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-omitted-hours-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-omitted-hours.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-too-long-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-too-long.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-too-short-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/timings-too-short.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/whitespace-chars-expected.txt: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tests/whitespace-chars.html: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tools/build.py: Added. (generate_test): (main): * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tools/parser.py: Added. (DictInit): (DictInit.__init__): (VTTCue): (VTTRegion): (Stylesheet): (W3CParser): (W3CParser.collect_characters): (W3CParser.skip_whitespace): (W3CParser.parse_percentage_string): (VTTParser): (VTTParser.__init__): (VTTParser.parse): (VTTParser.collect_block): (VTTParser.collect_region_settings): (VTTCueParser): (VTTCueParser.__init__): (VTTCueParser.collect_cue_timings_and_settings): (VTTCueParser.parse_settings): (VTTCueParser.collect_timestamp): (main): * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tools/spec_report.py: Added. (write_report): (main): * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/tools/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/file-parsing/w3c-import.log: Added. * LayoutTests/imported/w3c/web-platform-tests/webvtt/parsing/w3c-import.log: Added. * LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/buildtests: Removed. * LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/dat/tags.dat: Removed. * LayoutTests/media/track/opera/track/webvtt/parsing-cue-data/tests/tags.html: Removed. * LayoutTests/media/track/opera/track/webvtt/parsing/001.html: Removed. * LayoutTests/media/track/opera/track/webvtt/parsing/support/.htaccess: Removed. * LayoutTests/media/track/opera/track/webvtt/parsing/support/cue-counts.json: Removed. * LayoutTests/media/track/opera/track/webvtt/parsing/support/newlines.vtt: Removed. * LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-line.vtt: Removed. * LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-multiple.vtt: Removed. * LayoutTests/media/track/opera/track/webvtt/parsing/support/settings-position.vtt: Removed. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/mac/TestExpectations: * Source/WebCore/page/CaptionUserPreferences.h: (WebCore::CaptionUserPreferences::setTestingMode): * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetCaptionDisplayTestingMode): * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::didReceiveMessageToPage): (WTR::InjectedBundle::beginTesting): Canonical link: https://commits.webkit.org/268368@main
c382dcb
to
26938b1
Compare
Committed 268368@main (26938b1): https://commits.webkit.org/268368@main Reviewed commits have been landed. Closing PR #17852 and removing active labels. |
β¦efore setting caption mode https://bugs.webkit.org/show_bug.cgi?id=262680 Reviewed by Eric Carlson. The `captionDisplayMode` option was introduced in https://bugs.webkit.org/show_bug.cgi?id=261460 (PR: WebKit#17689). However, when I attempted to import WPT for webvtt/parsing with `captionDisplayMode` setting enabled, I found that the tests were failing intermittently on ios-wk2 (example: WebKit#17852 (comment)). The flakiness of these tests appears to be due to the fact that the `CaptionUserPreferencesTestingModeToken` instance may not always be initialized before the caption mode is set (https://github.com/WebKit/WebKit/blob/659f85098cf4322282a775cbd51eb58a4ed34022/Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp#L583). This instance is usually initialized on the `Internals` class's constructor during the WebKitTestRunner setup (https://github.com/WebKit/WebKit/blob/659f85098cf4322282a775cbd51eb58a4ed34022/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp#L888). In most cases, the `CaptionUserPreferencesTestingModeToken` instance is created in the `Internals` class constructor before `WKBundlePageSetCaptionDisplayMode` is called, but there are instances where it is not, particularly when tests are run concurrently. This leads to the tests failing. To address this issue, the WebKitTestRunner needs to ensure that the `CaptionUserPreferencesTestingModeToken` instance is always initialized before `WKBundlePageSetCaptionDisplayMode` is called, thus eliminating the flakiness of the tests. * Source/WebKit/Shared/API/APICaptionUserPreferencesTestingModeToken.h: Added. (API::CaptionUserPreferencesTestingModeToken::create): (API::CaptionUserPreferencesTestingModeToken::CaptionUserPreferencesTestingModeToken): * Source/WebKit/Shared/API/APIObject.h: * Source/WebKit/Shared/API/c/WKBase.h: * Source/WebKit/UIProcess/API/C/WKAPICast.h: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp: (WKBundlePageSetCaptionDisplayMode): (WKBundlePageCreateCaptionUserPreferencesTestingModeToken): (WKBundleSetCaptionDisplayMode): Deleted. * Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting): * Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.h: Canonical link: https://commits.webkit.org/269455@main
26938b1
c382dcb