Add unprefixed backdrop-filter behind a pref. #18059

mattwoodrow · 2023-09-22T00:50:16Z

`c950ad9`

Add unprefixed backdrop-filter behind a pref.
https://bugs.webkit.org/show_bug.cgi?id=261923
<rdar://115869595>

Reviewed by Simon Fraser.

We want to start being able to test this, before it's fully ready.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WTF/wtf/PlatformEnable.h:
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::computeHasReferenceFilter):
(WebCore::acceleratedPropertyDidChange):
* Source/WebCore/css/CSSProperties.json:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::isLayoutDependent):
(WebCore::ComputedStyleExtractor::valueForPropertyInStyle const):
* Source/WebCore/platform/animation/AcceleratedEffect.cpp:
(WebCore::acceleratedPropertyFromCSSProperty):
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::cssToGraphicsLayerProperty):
* Source/WebCore/rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForAnimation const):
* Source/WebCore/rendering/style/WillChangeData.cpp:
(WebCore::WillChangeData::createsContainingBlockForOutOfFlowPositioned const):
(WebCore::WillChangeData::canBeBackdropRoot const):
(WebCore::WillChangeData::propertyCreatesStackingContext):
(WebCore::propertyTriggersCompositing):

Canonical link: https://commits.webkit.org/268367@main

fd8c628

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-09-22T00:50:26Z

EWS run on previous version of this PR (hash 9773f41)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	⏳ 🛠 wincairo
⏳ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
❌ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
~~🛠 🧪 jsc-arm64~~	⏳ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-armv7-tests
	⏳ 🛠 watch		❌ 🛠 jsc-mips
	⏳ 🛠 watch-sim		❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-09-22T01:17:57Z

EWS run on previous version of this PR (hash e39428d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		❌ 🧪 jsc-mips-tests

smfr · 2023-09-22T19:09:54Z

Source/WTF/wtf/PlatformEnable.h

@@ -572,6 +572,9 @@
 #define ENABLE_CFPREFS_DIRECT_MODE 0
 #endif

+#if !defined(ENABLE_BACKDROP_FILTER)
+#define ENABLE_BACKDROP_FILTER 0


Do we really need this? If we do, I'd prefer it be ENABLE_UNPREFIXED_BACKDROP_FILTER

smfr · 2023-09-22T19:10:13Z

Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml

+  status: testable
+  category: css
+  humanReadableName: "CSS Backdrop Filter"
+  humanReadableDescription: "Enable backdrop-filter CSS property"


"Enable unprefixed backdrop-filter CSS property"

webkit-early-warning-system · 2023-09-24T01:34:25Z

EWS run on previous version of this PR (hash 1fb4468)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
❌ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-09-24T05:01:45Z

EWS run on previous version of this PR (hash 1e7552f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-09-24T07:29:45Z

EWS run on current version of this PR (hash fd8c628)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		⏳ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

https://bugs.webkit.org/show_bug.cgi?id=261923 <rdar://115869595> Reviewed by Simon Fraser. We want to start being able to test this, before it's fully ready. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WTF/wtf/PlatformEnable.h: * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/animation/KeyframeEffect.cpp: (WebCore::KeyframeEffect::computeHasReferenceFilter): (WebCore::acceleratedPropertyDidChange): * Source/WebCore/css/CSSProperties.json: * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::isLayoutDependent): (WebCore::ComputedStyleExtractor::valueForPropertyInStyle const): * Source/WebCore/platform/animation/AcceleratedEffect.cpp: (WebCore::acceleratedPropertyFromCSSProperty): * Source/WebCore/rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::startAnimation): (WebCore::RenderLayerBacking::cssToGraphicsLayerProperty): * Source/WebCore/rendering/RenderLayerCompositor.cpp: (WebCore::RenderLayerCompositor::requiresCompositingForAnimation const): * Source/WebCore/rendering/style/WillChangeData.cpp: (WebCore::WillChangeData::createsContainingBlockForOutOfFlowPositioned const): (WebCore::WillChangeData::canBeBackdropRoot const): (WebCore::WillChangeData::propertyCreatesStackingContext): (WebCore::propertyTriggersCompositing): Canonical link: https://commits.webkit.org/268367@main

webkit-commit-queue · 2023-09-24T08:52:45Z

Committed 268367@main (c950ad9): https://commits.webkit.org/268367@main

Reviewed commits have been landed. Closing PR #18059 and removing active labels.

mattwoodrow requested a review from graouts as a code owner September 22, 2023 00:50

mattwoodrow self-assigned this Sep 22, 2023

mattwoodrow added the Layout and Rendering For bugs with layout and rendering of Web pages. label Sep 22, 2023

mattwoodrow force-pushed the eng/unprefixed-backdrop-filter branch from 9773f41 to e39428d Compare September 22, 2023 01:05

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 22, 2023

smfr approved these changes Sep 22, 2023

View reviewed changes

mattwoodrow removed the merging-blocked Applied to prevent a change from being merged label Sep 24, 2023

mattwoodrow force-pushed the eng/unprefixed-backdrop-filter branch from e39428d to 1fb4468 Compare September 24, 2023 01:34

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 24, 2023

mattwoodrow removed the merging-blocked Applied to prevent a change from being merged label Sep 24, 2023

mattwoodrow force-pushed the eng/unprefixed-backdrop-filter branch from 1fb4468 to 1e7552f Compare September 24, 2023 05:01

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 24, 2023

mattwoodrow removed the merging-blocked Applied to prevent a change from being merged label Sep 24, 2023

mattwoodrow force-pushed the eng/unprefixed-backdrop-filter branch from 1e7552f to fd8c628 Compare September 24, 2023 07:28

mattwoodrow added the merge-queue Applied to send a pull request to merge-queue label Sep 24, 2023

webkit-commit-queue force-pushed the eng/unprefixed-backdrop-filter branch from fd8c628 to c950ad9 Compare September 24, 2023 08:52

webkit-commit-queue merged commit c950ad9 into WebKit:main Sep 24, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unprefixed backdrop-filter behind a pref. #18059

Add unprefixed backdrop-filter behind a pref. #18059

mattwoodrow commented Sep 22, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 22, 2023 •

edited

smfr Sep 22, 2023

smfr Sep 22, 2023

webkit-early-warning-system commented Sep 24, 2023 •

edited

webkit-early-warning-system commented Sep 24, 2023 •

edited

webkit-early-warning-system commented Sep 24, 2023 •

edited

webkit-commit-queue commented Sep 24, 2023

Add unprefixed backdrop-filter behind a pref. #18059

Add unprefixed backdrop-filter behind a pref. #18059

Conversation

mattwoodrow commented Sep 22, 2023 • edited by webkit-early-warning-system

c950ad9

webkit-early-warning-system commented Sep 22, 2023 • edited

webkit-early-warning-system commented Sep 22, 2023 • edited

smfr Sep 22, 2023

Choose a reason for hiding this comment

smfr Sep 22, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Sep 24, 2023 • edited

webkit-early-warning-system commented Sep 24, 2023 • edited

webkit-early-warning-system commented Sep 24, 2023 • edited

webkit-commit-queue commented Sep 24, 2023

mattwoodrow commented Sep 22, 2023 •

edited by webkit-early-warning-system

`c950ad9`

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 24, 2023 •

edited

webkit-early-warning-system commented Sep 24, 2023 •

edited

webkit-early-warning-system commented Sep 24, 2023 •

edited