Big drop in canvas performance above 3840px #18080

kkinnunen-apple · 2023-09-22T14:35:04Z

`45446c5`

Big drop in canvas performance above 3840px
https://bugs.webkit.org/show_bug.cgi?id=236173
rdar://88536159

Reviewed by Simon Fraser.

Limiting the accelerted canvas 2d context to arbitrary 5120*2880 is
not useful. The performance difference gets more beneficial to
hardware rasterization the higher the resolution.

The limit did not protect against hitting hardware rasterization
limits, since the limits are always per dimension, not per area.

As per above, capping based on any upper limit is not useful. Thus
remove the upper limit.

Reuse the unused lower limit as the trigger. The lower limit is
justified, as very small areas might be useful to rasterize with CPU.
Start the limit at 0, to match the previous behavior.

The hardware acceleration limits are checked in the respective
ImageBufferBackends, e.g. ImageBufferIOSurfaceBackend::calculateSafeSize.
This is done in WP for both GPUP mode and in-process mode. Both will
fall back to Unaccelerated.

Changes the RemoteRenderingBackend::createImageBuffer() to use
buffer options instead of rendering mode. The the buffer
options may be honored, but rendering mode would imply that it must
be honored. Later on when the rendering mode is more policy based on
rendering purpose, this is more clear.

* LayoutTests/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt:
* LayoutTests/compositing/canvas/accelerated-canvas-compositing-size-limit.html:
* LayoutTests/compositing/canvas/accelerated-small-canvas-compositing-expected.txt: Removed.
* LayoutTests/compositing/canvas/accelerated-small-canvas-compositing.html: Removed.
* LayoutTests/fast/canvas/image-buffer-backend-variants-expected.txt:
* LayoutTests/platform/ios/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt: Removed.
* LayoutTests/platform/ios/fast/canvas/image-buffer-backend-variants-expected.txt:
* LayoutTests/platform/mac-wk1/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt: Added.
* LayoutTests/platform/mac-wk1/fast/canvas/image-buffer-backend-variants-expected.txt:
* LayoutTests/platform/mac-wk2/TestExpectations:
* LayoutTests/platform/mac-wk2/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt: Removed.
* LayoutTests/platform/wincairo/TestExpectations:
* Source/WebCore/html/CanvasBase.cpp:
(WebCore::CanvasBase::shouldAccelerate const):
(WebCore::CanvasBase::allocateImageBuffer const):
* Source/WebCore/html/CanvasBase.h:
* Source/WebCore/page/Settings.yaml:

Canonical link: https://commits.webkit.org/268440@main

c87002e

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-22T14:36:26Z

EWS run on previous version of this PR (hash c0fde81)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	❌ 🛠 watch
	❌ 🛠 watch-sim

webkit-early-warning-system · 2023-09-22T16:03:01Z

EWS run on previous version of this PR (hash 28c6985)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	❌ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	❌ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-22T16:57:32Z

EWS run on previous version of this PR (hash 1a56d1f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	~~🛠 wpe~~	⏳ 🛠 wincairo
✅ 🧪 bindings	⏳ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	⏳ 🧪 ios-wk2	~~🧪 api-mac~~	⏳ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	⏳ 🛠 tv-sim
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-09-22T17:04:29Z

EWS run on previous version of this PR (hash 56ee661)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T09:08:58Z

EWS run on previous version of this PR (hash 88ea72a)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T10:15:36Z

EWS run on previous version of this PR (hash 97dc78e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	~~🛠 ios~~	~~🛠 mac~~	~~🛠 wpe~~	⏳ 🛠 wincairo
~~🧪 bindings~~	~~🛠 ios-sim~~	~~🛠 mac-AS-debug~~	~~🧪 wpe-wk2~~
~~🧪 webkitperl~~	~~🧪 ios-wk2~~	~~🧪 api-mac~~	~~🛠 gtk~~
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	~~🛠 tv-sim~~	~~🧪 mac-wk2-stress~~
	~~🛠 watch~~
	~~🛠 watch-sim~~

webkit-early-warning-system · 2023-09-25T10:19:29Z

EWS run on previous version of this PR (hash 42f06ac)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T11:45:27Z

EWS run on previous version of this PR (hash 0a563c7)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T18:52:07Z

EWS run on previous version of this PR (hash 5d63817)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	~~🛠 mac~~	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	⏳ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	⏳ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	⏳ 🧪 api-gtk
	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	⏳ 🛠 tv-sim	~~🧪 mac-wk2-stress~~
	⏳ 🛠 watch
	⏳ 🛠 watch-sim

webkit-early-warning-system · 2023-09-25T18:57:11Z

EWS run on current version of this PR (hash c87002e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=236173 rdar://88536159 Reviewed by Simon Fraser. Limiting the accelerted canvas 2d context to arbitrary 5120*2880 is not useful. The performance difference gets more beneficial to hardware rasterization the higher the resolution. The limit did not protect against hitting hardware rasterization limits, since the limits are always per dimension, not per area. As per above, capping based on any upper limit is not useful. Thus remove the upper limit. Reuse the unused lower limit as the trigger. The lower limit is justified, as very small areas might be useful to rasterize with CPU. Start the limit at 0, to match the previous behavior. The hardware acceleration limits are checked in the respective ImageBufferBackends, e.g. ImageBufferIOSurfaceBackend::calculateSafeSize. This is done in WP for both GPUP mode and in-process mode. Both will fall back to Unaccelerated. Changes the RemoteRenderingBackend::createImageBuffer() to use buffer options instead of rendering mode. The the buffer options may be honored, but rendering mode would imply that it must be honored. Later on when the rendering mode is more policy based on rendering purpose, this is more clear. * LayoutTests/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt: * LayoutTests/compositing/canvas/accelerated-canvas-compositing-size-limit.html: * LayoutTests/compositing/canvas/accelerated-small-canvas-compositing-expected.txt: Removed. * LayoutTests/compositing/canvas/accelerated-small-canvas-compositing.html: Removed. * LayoutTests/fast/canvas/image-buffer-backend-variants-expected.txt: * LayoutTests/platform/ios/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt: Removed. * LayoutTests/platform/ios/fast/canvas/image-buffer-backend-variants-expected.txt: * LayoutTests/platform/mac-wk1/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt: Added. * LayoutTests/platform/mac-wk1/fast/canvas/image-buffer-backend-variants-expected.txt: * LayoutTests/platform/mac-wk2/TestExpectations: * LayoutTests/platform/mac-wk2/compositing/canvas/accelerated-canvas-compositing-size-limit-expected.txt: Removed. * LayoutTests/platform/wincairo/TestExpectations: * Source/WebCore/html/CanvasBase.cpp: (WebCore::CanvasBase::shouldAccelerate const): (WebCore::CanvasBase::allocateImageBuffer const): * Source/WebCore/html/CanvasBase.h: * Source/WebCore/page/Settings.yaml: Canonical link: https://commits.webkit.org/268440@main

webkit-commit-queue · 2023-09-26T08:29:35Z

Committed 268440@main (45446c5): https://commits.webkit.org/268440@main

Reviewed commits have been landed. Closing PR #18080 and removing active labels.

kkinnunen-apple requested review from cdumez and rniwa as code owners September 22, 2023 14:35

kkinnunen-apple self-assigned this Sep 22, 2023

kkinnunen-apple added the Canvas Bugs related to the canvas element. label Sep 22, 2023

webkit-ews-buildbot added merging-blocked Applied to prevent a change from being merged labels Sep 22, 2023

kkinnunen-apple removed the merging-blocked Applied to prevent a change from being merged label Sep 22, 2023

kkinnunen-apple force-pushed the imagebuffer-accelerated-no-limits-1 branch from c0fde81 to 28c6985 Compare September 22, 2023 16:02

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 22, 2023

kkinnunen-apple removed the merging-blocked Applied to prevent a change from being merged label Sep 22, 2023

kkinnunen-apple force-pushed the imagebuffer-accelerated-no-limits-1 branch from 28c6985 to 1a56d1f Compare September 22, 2023 16:52

kkinnunen-apple force-pushed the imagebuffer-accelerated-no-limits-1 branch from 1a56d1f to 56ee661 Compare September 22, 2023 17:01

kkinnunen-apple requested review from smfr, litherum and shallawa and removed request for rniwa and cdumez September 22, 2023 17:05

smfr approved these changes Sep 22, 2023

View reviewed changes

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 22, 2023

kkinnunen-apple removed the merging-blocked Applied to prevent a change from being merged label Sep 25, 2023

kkinnunen-apple force-pushed the imagebuffer-accelerated-no-limits-1 branch from 56ee661 to 88ea72a Compare September 25, 2023 09:05

kkinnunen-apple force-pushed the imagebuffer-accelerated-no-limits-1 branch from 88ea72a to 97dc78e Compare September 25, 2023 10:14

kkinnunen-apple force-pushed the imagebuffer-accelerated-no-limits-1 branch from 97dc78e to 42f06ac Compare September 25, 2023 10:16

kkinnunen-apple force-pushed the imagebuffer-accelerated-no-limits-1 branch from 42f06ac to 0a563c7 Compare September 25, 2023 11:45

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 25, 2023

kkinnunen-apple removed the merging-blocked Applied to prevent a change from being merged label Sep 25, 2023

kkinnunen-apple force-pushed the imagebuffer-accelerated-no-limits-1 branch from 0a563c7 to 5d63817 Compare September 25, 2023 18:50

kkinnunen-apple force-pushed the imagebuffer-accelerated-no-limits-1 branch from 5d63817 to c87002e Compare September 25, 2023 18:55

kkinnunen-apple added the merge-queue Applied to send a pull request to merge-queue label Sep 26, 2023

webkit-commit-queue force-pushed the imagebuffer-accelerated-no-limits-1 branch from c87002e to 45446c5 Compare September 26, 2023 08:29

webkit-commit-queue merged commit 45446c5 into WebKit:main Sep 26, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Big drop in canvas performance above 3840px #18080

Big drop in canvas performance above 3840px #18080

kkinnunen-apple commented Sep 22, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-commit-queue commented Sep 26, 2023

Big drop in canvas performance above 3840px #18080

Big drop in canvas performance above 3840px #18080

Conversation

kkinnunen-apple commented Sep 22, 2023 • edited by webkit-early-warning-system

45446c5

webkit-early-warning-system commented Sep 22, 2023 • edited

webkit-early-warning-system commented Sep 22, 2023 • edited

webkit-early-warning-system commented Sep 22, 2023 • edited

webkit-early-warning-system commented Sep 22, 2023 • edited

webkit-early-warning-system commented Sep 25, 2023 • edited

webkit-early-warning-system commented Sep 25, 2023 • edited

webkit-early-warning-system commented Sep 25, 2023 • edited

webkit-early-warning-system commented Sep 25, 2023 • edited

webkit-early-warning-system commented Sep 25, 2023 • edited

webkit-early-warning-system commented Sep 25, 2023 • edited

webkit-commit-queue commented Sep 26, 2023

kkinnunen-apple commented Sep 22, 2023 •

edited by webkit-early-warning-system

`45446c5`

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 22, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited

webkit-early-warning-system commented Sep 25, 2023 •

edited