-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filters] Enable CoreGraphics drop shadow filter #18110
[Filters] Enable CoreGraphics drop shadow filter #18110
Conversation
EWS run on previous version of this PR (hash 1cd886e) |
@@ -124,7 +124,7 @@ OptionSet<FilterRenderingMode> FEColorMatrix::supportedFilterRenderingModes() co | |||
if (FEColorMatrixCoreImageApplier::supportsCoreImageRendering(*this)) | |||
modes.add(FilterRenderingMode::Accelerated); | |||
#endif | |||
#if HAVE(CGSTYLE_COLORMATRIX_BLUR) | |||
#if 0 && HAVE(CGSTYLE_COLORMATRIX_BLUR) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a comment in here (and in FEGaussianBlur.cpp) to explain why we're doing 0 &&
. Without any context it looks odd.
1cd886e
to
736ade9
Compare
736ade9
to
ef12d81
Compare
EWS run on current version of this PR (hash ef12d81)
|
https://bugs.webkit.org/show_bug.cgi?id=261925 rdar://98820279 Reviewed by Cameron McCormack. Software filters use ImageBuffers to generate the result of their applying to the target element. These buffers can take significant amount of memory if the target element is large or the number of effects are big. CoreGraphics provides a better way to apply FilterEffects. A CGStyle can be used to apply the FilterEffect to the current drawing. Also beginTransparencyLayer()/ endTransparencyLayer() can be used to force applying the FilterEffect only when composting the layer to the destination GraphicsContext. This will treat the drawing commands between beginning and ending the transparency layer as a unit of drawing. Although ColorMatrix and GussianBlur CGStyles are available on macOS Sonoma and iOS 17, only DropShadow style will be enabled by this patch. The other styles will be enabled in future patches after fixing the expected fuzziness. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/platform/graphics/filters/FEColorMatrix.cpp: (WebCore::FEColorMatrix::supportedFilterRenderingModes const): * Source/WebCore/platform/graphics/filters/FEGaussianBlur.cpp: (WebCore::FEGaussianBlur::supportedFilterRenderingModes const): Canonical link: https://commits.webkit.org/268354@main
ef12d81
to
318e176
Compare
Committed 268354@main (318e176): https://commits.webkit.org/268354@main Reviewed commits have been landed. Closing PR #18110 and removing active labels. |
318e176
ef12d81
π§ͺ mac-AS-debug-wk2