[GTK][WPE] Gardening LayoutTests/webrtc/video-disabled-black.html #18181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 57313fa)
|
abstractmachines
force-pushed
the
gardening/gtk-wpe/layouttests/webrtc/video-disabled-black.html
branch
from
57313fa
to
1a8dfbc
Compare
|
EWS run on current version of this PR (hash 1a8dfbc)
|
🧪 style
|
EWS run on previous version of this PR (hash 1a8dfbc)
|
abstractmachines
force-pushed
the
gardening/gtk-wpe/layouttests/webrtc/video-disabled-black.html
branch
from
1a8dfbc
to
6679f45
Compare
|
EWS run on previous version of this PR (hash 6679f45)
|
clopez
reviewed
Sep 26, 2023
| @@ -3470,6 +3470,7 @@ webkit.org/b/261024 svg/text/small-fonts-in-html5.html [ Failure ImageOnlyFailur | |||
| webkit.org/b/261024 webrtc/video-maxFramerate.html [ Pass Timeout ] | |||
| webkit.org/b/261024 webrtc/video-replace-muted-track.html [ Pass Timeout ] | |||
| webkit.org/b/261024 webrtc/video-unmute.html [ Pass Timeout ] | |||
| webkit.org/b/261024 webrtc/video-disabled-black.html [ Skip ] | |||
There was a problem hiding this comment.
We usually prefer to indicate the possible outcomes of the test (Crash Pass) rather than skipping it.
If a test is skipped then the bots will not run it, so we will not get any further notification if/when the test starts passing back or if it has a different result (like Timeout).
There was a problem hiding this comment.
Done :) Thanks for the note. Now this just needs proper labels to merge, e.g. unsafe-merge-queue, would appreciate that if you'd add those labels @clopez (and also remove merging-blocked label if applicable). Thanks!
abstractmachines
force-pushed
the
gardening/gtk-wpe/layouttests/webrtc/video-disabled-black.html
branch
from
6679f45
to
f87fa2a
Compare
|
EWS run on current version of this PR (hash f87fa2a)
|
obyknovenius
added
the
unsafe-merge-queue
Unreviewed test gardening. Test was gardened a couple of weeks ago in webkit.org/b/261024; and webkit.org/b/254212 is also related to this test as a fix. Since webkit.org/b/254212, test has been flaky; prior to that, it failed in bots. Generally a flaky test as noted in 261024 which is still open. Noted in existing bugs 261024, 254212; moved expectations up to glib. * LayoutTests/platform/glib/TestExpectations: move expectation here for flakiness * LayoutTests/platform/gtk/TestExpectations: Canonical link: https://commits.webkit.org/268498@main
webkit-commit-queue
force-pushed
the
gardening/gtk-wpe/layouttests/webrtc/video-disabled-black.html
branch
from
f87fa2a
to
c2c3e60
Compare
|
Test gardening commit 268498@main (c2c3e60): https://commits.webkit.org/268498@main Reviewed commits have been landed. Closing PR #18181 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c2c3e60
f87fa2a