generate-bundle fails at installing toml

[obyknovenius]

3a33119

`generate-bundle` fails at installing `toml`
https://bugs.webkit.org/show_bug.cgi?id=262184

Reviewed by Jonathan Bedard.

After `268269@main` `pyparsing` must be specified as a implicit
dependency of `toml`.

* Tools/Scripts/webkitpy/__init__.py:

Canonical link: https://commits.webkit.org/268547@main

af387f0

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
❌ 🛠 🧪 merge	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash af387f0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
❌ 🛠 🧪 merge	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

[webkit-commit-queue]

Commit message contains (OOPS!) and no reviewer found, blocking PR #18279

[JonWBedard]

This won't work and will end up in an infinite loop with a fresh install. We need #18232.

[obyknovenius]

This won't work and will end up in an infinite loop with a fresh install. We need #18232.

While I agree that we need #18232, I can assure you that this works. You can try it by wiping out Tools/Scripts/libraries/autoinstalled directory and running generate-bundle --help.

[JonWBedard]

This won't work and will end up in an infinite loop with a fresh install. We need #18232.

While I agree that we need #18232, I can assure you that this works. You can try it by wiping out Tools/Scripts/libraries/autoinstalled directory and running generate-bundle --help.

Sorry for blocking this temporarily. If you look at what AutoInstall.install(...) does, if first checks if the library we're installing is in a small list of libraries required for setup tools (and tomli is one of those libraries). The trouble with this is that this check actually happens before we install any dependencies of that library. So in tomli's case, we would normally expect that pyparsing is already installed, but that won't be true (or at least, wasn't true) because pyparsing wasn't one of the libraries required to use setup tools. I was mistaken about the infinite loop (perhaps that was older behavior?), but I do stand by this PR not doing what you thought it did without https://commits.webkit.org/268542@main. In any case, r+ed this now!

[JonWBedard]

Wait, I'm sorry, this is toml, not tomli, I was completely wrong!

[webkit-commit-queue]

Committed 268547@main (3a33119): https://commits.webkit.org/268547@main

Reviewed commits have been landed. Closing PR #18279 and removing active labels.

[obyknovenius]

Wait, I'm sorry, this is toml, not tomli, I was completely wrong!

It is easy to get confused. Thank you for merging it!