[visionOS] Remote Effects don't work inside of `pointer-events: none` scrollers #18351

etiennesegonzac · 2023-09-28T14:35:10Z

`0fed4da`

[visionOS] Remote Effects don't work inside of `pointer-events: none` scrollers
https://bugs.webkit.org/show_bug.cgi?id=262307
<rdar://115776753>

Reviewed by NOBODY (OOPS!).

Remote Effects use CA-based hit-testing.
So when we set `userInteractionEnabled = NO` on a `pointer-events: none`
ScrollView, we also prevent potential `pointer-events: auto` children
from hit-testing.

This patch introduces a new `_wk_userInteractive` flag on
WKChildScrollViews that disables the scroll container without blocking
hit-testing of its children. Effectively taking the view out of
WKHitTesting without impacting its layer's `allowsHitTesting` property.

* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm:
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToUIView):
Use `_wk_userInteractive` instead of `userInteractionEnabled` for
WKChildScrollViews.

* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h:
* Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm:
(-[WKChildScrollView initWithFrame:]):
Introduce the new `_wk_userInteractive` property defaulting to YES.
(WebKit::collectDescendantViewsAtPoint):
(WebKit::collectDescendantViewsInRect):
Remove the FIXME since we use `userInteractionEnabled` for
`WKNativelyInteractible` views.
Skip WKChildScrollViews marked as `_wk_userInteractive = NO`.

* Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h:
Clean-up, remove unused member variable.

* Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm:
(dumpCALayer):
Add `allowsHitTesting` to the dump format when Interaction Regions are
turned on.

* LayoutTests/interaction-region/scroll-view-hit-testing-expected.txt: Added.
* LayoutTests/interaction-region/scroll-view-hit-testing.html: Added.
Add a test covering the change, based on
`touch-scroll-pointer-events-none.html`.
* LayoutTests/interaction-region/interaction-layers-culling-expected.txt:
* LayoutTests/interaction-region/layer-tree-expected.txt:
Update expectations with the new format.

0fed4da

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-09-28T14:35:22Z

EWS run on previous version of this PR (hash 598e129)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

etiennesegonzac · 2023-09-28T14:37:41Z

Hi @aprotyas ! Mentioning you here because this seems tangentially related to https://bugs.webkit.org/show_bug.cgi?id=258255

webkit-early-warning-system · 2023-09-28T17:23:21Z

EWS run on previous version of this PR (hash 578bd67)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

smfr · 2023-09-28T20:32:56Z

Source/WebCore/rendering/RenderLayerScrollableArea.h

@@ -225,6 +225,9 @@ class RenderLayerScrollableArea final : public ScrollableArea {
    void updateScrollbarsAfterStyleChange(const RenderStyle* oldStyle);
    void updateScrollbarsAfterLayout();

+    ScrollbarMode horizontalScrollbarMode() const final;


I don't think pointer-events:none should affect the scrollbar mode (it doesn't affect how scrollbars render, only whether the user can interact).

it was a bit fragile having completely different codepaths calling into setScrollEnabled anyway.

Trying a simpler approach: a custom property on WKChildScrollView.

LayoutTests/interaction-region/scroll-view-hit-testing.html

Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm

webkit-early-warning-system · 2023-09-29T18:30:16Z

EWS run on previous version of this PR (hash 3455e15)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	❌ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp

webkit-early-warning-system · 2023-09-29T20:55:32Z

EWS run on previous version of this PR (hash dab2be6)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-05T21:50:40Z

EWS run on previous version of this PR (hash fa1ef3e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-06T08:30:29Z

EWS run on previous version of this PR (hash f551fca)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	⏳ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-11-29T14:45:43Z

EWS run on previous version of this PR (hash 3e62c49)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

… scrollers https://bugs.webkit.org/show_bug.cgi?id=262307 <rdar://115776753> Reviewed by NOBODY (OOPS!). Remote Effects use CA-based hit-testing. So when we set `userInteractionEnabled = NO` on a `pointer-events: none` ScrollView, we also prevent potential `pointer-events: auto` children from hit-testing. This patch introduces a new `_wk_userInteractive` flag on WKChildScrollViews that disables the scroll container without blocking hit-testing of its children. Effectively taking the view out of WKHitTesting without impacting its layer's `allowsHitTesting` property. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm: (WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToUIView): Use `_wk_userInteractive` instead of `userInteractionEnabled` for WKChildScrollViews. * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.h: * Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteLayerTreeViews.mm: (-[WKChildScrollView initWithFrame:]): Introduce the new `_wk_userInteractive` property defaulting to YES. (WebKit::collectDescendantViewsAtPoint): (WebKit::collectDescendantViewsInRect): Remove the FIXME since we use `userInteractionEnabled` for `WKNativelyInteractible` views. Skip WKChildScrollViews marked as `_wk_userInteractive = NO`. * Source/WebKit/UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.h: Clean-up, remove unused member variable. * Source/WebKit/UIProcess/API/Cocoa/WKWebViewTesting.mm: (dumpCALayer): Add `allowsHitTesting` to the dump format when Interaction Regions are turned on. * LayoutTests/interaction-region/scroll-view-hit-testing-expected.txt: Added. * LayoutTests/interaction-region/scroll-view-hit-testing.html: Added. Add a test covering the change, based on `touch-scroll-pointer-events-none.html`. * LayoutTests/interaction-region/interaction-layers-culling-expected.txt: * LayoutTests/interaction-region/layer-tree-expected.txt: Update expectations with the new format.

webkit-early-warning-system · 2024-01-04T18:05:49Z

EWS run on current version of this PR (hash 0fed4da)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 gtk
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch
	✅ 🛠 watch-sim

etiennesegonzac requested a review from cdumez as a code owner September 28, 2023 14:35

etiennesegonzac self-assigned this Sep 28, 2023

etiennesegonzac added the Layout and Rendering For bugs with layout and rendering of Web pages. label Sep 28, 2023

etiennesegonzac requested review from smfr and hortont424 September 28, 2023 14:35

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 28, 2023

etiennesegonzac removed the merging-blocked Applied to prevent a change from being merged label Sep 28, 2023

etiennesegonzac force-pushed the rdar-115776753 branch from 598e129 to 578bd67 Compare September 28, 2023 17:23

smfr reviewed Sep 28, 2023

View reviewed changes

pxlcoder reviewed Sep 28, 2023

View reviewed changes

Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTreePropertyApplier.mm Outdated Show resolved Hide resolved

etiennesegonzac force-pushed the rdar-115776753 branch from 578bd67 to 3455e15 Compare September 29, 2023 18:30

etiennesegonzac commented Sep 29, 2023

View reviewed changes

Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp Outdated Show resolved Hide resolved

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 29, 2023

etiennesegonzac removed the merging-blocked Applied to prevent a change from being merged label Sep 29, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 29, 2023

etiennesegonzac removed the merging-blocked Applied to prevent a change from being merged label Sep 29, 2023

etiennesegonzac force-pushed the rdar-115776753 branch from 3455e15 to dab2be6 Compare September 29, 2023 20:55

etiennesegonzac requested a review from smfr September 29, 2023 21:04

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Sep 30, 2023

etiennesegonzac removed the merging-blocked Applied to prevent a change from being merged label Oct 1, 2023

etiennesegonzac requested a review from graouts October 4, 2023 09:12

etiennesegonzac force-pushed the rdar-115776753 branch from dab2be6 to fa1ef3e Compare October 5, 2023 21:50

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 6, 2023

etiennesegonzac removed the merging-blocked Applied to prevent a change from being merged label Oct 6, 2023

etiennesegonzac force-pushed the rdar-115776753 branch from fa1ef3e to f551fca Compare October 6, 2023 08:30

etiennesegonzac force-pushed the rdar-115776753 branch from f551fca to 3e62c49 Compare November 29, 2023 14:45

etiennesegonzac force-pushed the rdar-115776753 branch from 3e62c49 to 0fed4da Compare January 4, 2024 18:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[visionOS] Remote Effects don't work inside of `pointer-events: none` scrollers #18351

[visionOS] Remote Effects don't work inside of `pointer-events: none` scrollers #18351

etiennesegonzac commented Sep 28, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Sep 28, 2023 •

edited

etiennesegonzac commented Sep 28, 2023

webkit-early-warning-system commented Sep 28, 2023 •

edited

smfr Sep 28, 2023

etiennesegonzac Sep 29, 2023

webkit-early-warning-system commented Sep 29, 2023 •

edited

webkit-early-warning-system commented Sep 29, 2023 •

edited

webkit-early-warning-system commented Oct 5, 2023 •

edited

webkit-early-warning-system commented Oct 6, 2023 •

edited

webkit-early-warning-system commented Nov 29, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2024 •

edited

[visionOS] Remote Effects don't work inside of pointer-events: none scrollers #18351

Are you sure you want to change the base?

[visionOS] Remote Effects don't work inside of pointer-events: none scrollers #18351

Conversation

etiennesegonzac commented Sep 28, 2023 • edited by webkit-early-warning-system

0fed4da

webkit-early-warning-system commented Sep 28, 2023 • edited

etiennesegonzac commented Sep 28, 2023

webkit-early-warning-system commented Sep 28, 2023 • edited

smfr Sep 28, 2023

Choose a reason for hiding this comment

etiennesegonzac Sep 29, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Sep 29, 2023 • edited

webkit-early-warning-system commented Sep 29, 2023 • edited

webkit-early-warning-system commented Oct 5, 2023 • edited

webkit-early-warning-system commented Oct 6, 2023 • edited

webkit-early-warning-system commented Nov 29, 2023 • edited

webkit-early-warning-system commented Jan 4, 2024 • edited

[visionOS] Remote Effects don't work inside of `pointer-events: none` scrollers #18351

[visionOS] Remote Effects don't work inside of `pointer-events: none` scrollers #18351

etiennesegonzac commented Sep 28, 2023 •

edited by webkit-early-warning-system

`0fed4da`

webkit-early-warning-system commented Sep 28, 2023 •

edited

webkit-early-warning-system commented Sep 28, 2023 •

edited

webkit-early-warning-system commented Sep 29, 2023 •

edited

webkit-early-warning-system commented Sep 29, 2023 •

edited

webkit-early-warning-system commented Oct 5, 2023 •

edited

webkit-early-warning-system commented Oct 6, 2023 •

edited

webkit-early-warning-system commented Nov 29, 2023 •

edited

webkit-early-warning-system commented Jan 4, 2024 •

edited