[UnifiedPDF] Get initial painting working #18359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on current version of this PR (hash 6dbd5dc)
|
rr-codes
reviewed
Sep 28, 2023
| @@ -148,6 +148,11 @@ | |||
| m_view->frame()->document()->loader()->addArchiveResource(resource.releaseNonNull()); | |||
| } | |||
|
|
|||
| void PDFPluginBase::geometryDidChange(const IntSize& pluginSize, const AffineTransform& pluginToRootViewTransform) | |||
There was a problem hiding this comment.
is the compiler going to complain here about unused parameter?
There was a problem hiding this comment.
Thankfully WebKit doesn't enable that silly warning
rr-codes
reviewed
Sep 28, 2023
|
|
||
| void UnifiedPDFPlugin::paint(GraphicsContext& context, const WebCore::IntRect& rect) | ||
| { | ||
| ALWAYS_LOG_WITH_STREAM(stream << "UnifiedPDFPlugin::paint " << rect); |
hortont424
approved these changes
Sep 28, 2023
hortont424
approved these changes
Sep 28, 2023
|
|
||
| if (!m_view) | ||
| return; | ||
|
|
There was a problem hiding this comment.
Is there something missing here?
shallawa
reviewed
Sep 28, 2023
|
|
||
| auto imageBuffer = ImageBuffer::create(m_size, RenderingPurpose::Unspecified, 1.0, DestinationColorSpace::SRGB(), PixelFormat::BGRA8); |
There was a problem hiding this comment.
How is this code going to deal with large PDF files? The maximum size of an ImageBuffer is 4096 x 4096 pixels. Beyond that ImageBuffer is going to scale the context. So the PDF will be pixelated.
https://bugs.webkit.org/show_bug.cgi?id=262311 rdar://116185973 Reviewed by Tim Horton. Start getting PDF drawing working for Unified PDF. Currently this just draws the first page via `CGPDFDocumentCreateWithProvider()` and `CGPDFDocumentGetPage()`. Move two bits of code into PDFPluginBase; first, have it handle `geometryDidChange()` so we can store the size. Second, because UnifiedPDFPlugin isn't layer-backed, we need to plumb through a `paint()` function from `PluginView`. * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm: (WebKit::PDFPlugin::geometryDidChange): * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.h: (WebKit::PDFPluginBase::paint): (WebKit::PDFPluginBase::size const): (WebKit::PDFPluginBase::geometryDidChange): Deleted. * Source/WebKit/WebProcess/Plugins/PDF/PDFPluginBase.mm: (WebKit::PDFPluginBase::geometryDidChange): * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.h: * Source/WebKit/WebProcess/Plugins/PDF/UnifiedPDF/UnifiedPDFPlugin.mm: (WebKit::UnifiedPDFPlugin::createPDFDocument): (WebKit::UnifiedPDFPlugin::installPDFDocument): (WebKit::UnifiedPDFPlugin::paint): (WebKit::UnifiedPDFPlugin::geometryDidChange): * Source/WebKit/WebProcess/Plugins/PluginView.cpp: (WebKit::PluginView::paint): Canonical link: https://commits.webkit.org/268610@main
webkit-commit-queue
force-pushed
the
eng/UnifiedPDF-Get-initial-painting-working
branch
from
6dbd5dc
to
8b9d4c4
Compare
|
Committed 268610@main (8b9d4c4): https://commits.webkit.org/268610@main Reviewed commits have been landed. Closing PR #18359 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8b9d4c4
6dbd5dc
🧪 wpe-wk2