Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issue when !ENABLE(FILTERS_LEVEL_2) #18421

Merged
merged 1 commit into from
Sep 29, 2023
Merged

Fix build issue when !ENABLE(FILTERS_LEVEL_2) #18421

merged 1 commit into from
Sep 29, 2023

Conversation

foopoiuyt
Copy link
Contributor

@foopoiuyt foopoiuyt commented Sep 29, 2023 •
edited by webkit-early-warning-system
Loading

@foopoiuyt foopoiuyt self-assigned this Sep 29, 2023
@foopoiuyt foopoiuyt added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Sep 29, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 29, 2023 •
edited
Loading

EWS run on current version of this PR (hash 9433a3e)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@foopoiuyt foopoiuyt added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 29, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-build-issue-when-ENABLEFILTERS_LEVEL_2 branch from 9433a3e to 82836a9 Compare September 29, 2023 19:47
@foopoiuyt
Fix build issue when !ENABLE(FILTERS_LEVEL_2)
c8ad412 
https://bugs.webkit.org/show_bug.cgi?id=262384

Unreviewed build fix

Add enable check around use of cssUnprefixedBackdropFilterEnabled

* Source/WebCore/rendering/RenderLayer.cpp:

Canonical link: https://commits.webkit.org/268665@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-build-issue-when-ENABLEFILTERS_LEVEL_2 branch from 82836a9 to c8ad412 Compare September 29, 2023 19:50
@webkit-commit-queue
Copy link
Collaborator

Committed 268665@main (c8ad412): https://commits.webkit.org/268665@main

Reviewed commits have been landed. Closing PR #18421 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c8ad412 into WebKit:main Sep 29, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@foopoiuyt foopoiuyt

Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
Milestone
No milestone
3 participants
@foopoiuyt @webkit-early-warning-system @webkit-commit-queue