Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run-webkit-tests broken with python 3.12 due to error in beautifulsoup4 #18430

Merged
merged 1 commit into from
Sep 30, 2023
Merged

run-webkit-tests broken with python 3.12 due to error in beautifulsoup4 #18430

merged 1 commit into from
Sep 30, 2023

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Sep 29, 2023 •
edited by webkit-early-warning-system
Loading

@mcatanzaro mcatanzaro self-assigned this Sep 29, 2023
@mcatanzaro mcatanzaro added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Sep 29, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 29, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 1e93d67)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 watch-sim

@mcatanzaro
Copy link
Contributor Author

CC @gsnedders

gsnedders
gsnedders reviewed Sep 29, 2023
View reviewed changes
Copy link
Contributor

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks fine as a non-reviewer, but it might be nice to try and go all the way to 4.12.0 given that should work on all Python 3 versions we care about.

Tools/Scripts/webkitpy/__init__.py Outdated Show resolved Hide resolved
@mcatanzaro mcatanzaro force-pushed the eng/run-webkit-tests-broken-with-python-3-12-due-to-error-in-beautifulsoup4 branch from 1e93d67 to ac0fb61 Compare September 29, 2023 22:38
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Sep 29, 2023 •
edited
Loading

EWS run on current version of this PR (hash ac0fb61)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 webkitpy ✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

gsnedders
gsnedders reviewed Sep 30, 2023
View reviewed changes
Copy link
Contributor

@gsnedders gsnedders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-reviewer r+

@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Sep 30, 2023
@webkit-commit-queue webkit-commit-queue force-pushed the eng/run-webkit-tests-broken-with-python-3-12-due-to-error-in-beautifulsoup4 branch from ac0fb61 to 00cd7de Compare September 30, 2023 15:35
@webkit-commit-queue
Copy link
Collaborator

Committed 268694@main (00cd7de): https://commits.webkit.org/268694@main

Reviewed commits have been landed. Closing PR #18430 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 00cd7de into WebKit:main Sep 30, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsnedders gsnedders gsnedders left review comments

@philn philn philn approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

@facetothefate facetothefate Awaiting requested review from facetothefate

Assignees

@mcatanzaro mcatanzaro

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@mcatanzaro @webkit-early-warning-system @webkit-commit-queue @philn @gsnedders