Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issue #18509

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Fix build issue #18509

merged 1 commit into from
Oct 2, 2023

Conversation

pvollan
Copy link
Contributor

@pvollan pvollan commented Oct 2, 2023 •
edited by webkit-early-warning-system
Loading

@pvollan pvollan self-assigned this Oct 2, 2023
@pvollan pvollan added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Oct 2, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 2, 2023 •
edited
Loading

EWS run on current version of this PR (hash a38be2a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

szewai
szewai approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@szewai szewai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@pvollan pvollan added the merge-queue Applied to send a pull request to merge-queue label Oct 2, 2023
@pvollan
Copy link
Contributor Author

pvollan commented Oct 2, 2023

r=me

Thanks for reviewing!

@pvollan
Fix build issue
260ad48 
https://bugs.webkit.org/show_bug.cgi?id=262503
rdar://116140701

Reviewed by Sihui Liu.

Some items in the plist were incorrectly put inside a dictionary.

* Source/WebKit/Shared/AuxiliaryProcessExtensions/NetworkingExtension-Info.plist:

Canonical link: https://commits.webkit.org/268755@main
@webkit-commit-queue
Copy link
Collaborator

Committed 268755@main (260ad48): https://commits.webkit.org/268755@main

Reviewed commits have been landed. Closing PR #18509 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 260ad48 into WebKit:main Oct 2, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szewai szewai szewai approved these changes

@achristensen07 achristensen07 Awaiting requested review from achristensen07

@brentfulgham brentfulgham Awaiting requested review from brentfulgham

Assignees

@pvollan pvollan

Labels
WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Projects
None yet
Milestone
No milestone
4 participants
@pvollan @webkit-early-warning-system @webkit-commit-queue @szewai