Use WTF::map() in ScriptArguments::getArgumentsAsStrings() instead of uncheckedAppend() #18527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash ee534c3) |
darinadler
approved these changes
Oct 3, 2023
| if (JSC::jsDynamicCast<JSC::ProxyObject*>(argument)) | ||
| return "[object Proxy]"_s; | ||
|
|
||
| String result; |
There was a problem hiding this comment.
Does this have to be defined here instead of where it is initialized.
There was a problem hiding this comment.
Oh, I just moved the code as is but I don't think there is a reason to defined it here. I'll update.
cdumez
force-pushed
the
262519_argumentsAsStrings_WTF_map
branch
from
ee534c3
to
6ee2394
Compare
|
EWS run on current version of this PR (hash 6ee2394) |
… uncheckedAppend() https://bugs.webkit.org/show_bug.cgi?id=262519 Reviewed by Darin Adler. Use WTF::map() in `ScriptArguments::getArgumentsAsStrings()` instead of `uncheckedAppend()`. It is more efficient, now that `uncheckedAppend()` is just an alias to `append()`. * Source/JavaScriptCore/inspector/ScriptArguments.cpp: (Inspector::argumentAsString): (Inspector::ScriptArguments::getArgumentAtIndexAsString const): (Inspector::ScriptArguments::getArgumentsAsStrings const): Canonical link: https://commits.webkit.org/268793@main
webkit-commit-queue
force-pushed
the
262519_argumentsAsStrings_WTF_map
branch
from
6ee2394
to
9152805
Compare
|
Committed 268793@main (9152805): https://commits.webkit.org/268793@main Reviewed commits have been landed. Closing PR #18527 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9152805
6ee2394
🧪 wpe-wk2🧪 gtk-wk2🧪 mac-AS-debug-wk2