Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character #18597

Merged
merged 1 commit into from
Oct 4, 2023
Merged

WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character #18597

merged 1 commit into from
Oct 4, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Oct 3, 2023 •
edited by webkit-early-warning-system
Loading

ee2c346

WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character
https://bugs.webkit.org/show_bug.cgi?id=262587

Reviewed by Alan Baradlay.

WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character.
It is a UChar, which is guaranteed to be 16 bit.

* Source/WebCore/platform/graphics/WidthCache.h:

Canonical link: https://commits.webkit.org/268822@main

6790a9d

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
❌ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
  🛠 watch-sim

@cdumez cdumez self-assigned this Oct 3, 2023
@cdumez cdumez added the Layout and Rendering For bugs with layout and rendering of Web pages. label Oct 3, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 3, 2023 •
edited
Loading

EWS run on current version of this PR (hash 6790a9d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
❌ 🛠 tv   🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
  🛠 watch-sim

@cdumez cdumez marked this pull request as ready for review October 4, 2023 01:11
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Oct 4, 2023
@cdumez
WidthCache::SingleCharMap doesn't need to use 32 bits to store the ke…
ee2c346 
…y character

https://bugs.webkit.org/show_bug.cgi?id=262587

Reviewed by Alan Baradlay.

WidthCache::SingleCharMap doesn't need to use 32 bits to store the key character.
It is a UChar, which is guaranteed to be 16 bit.

* Source/WebCore/platform/graphics/WidthCache.h:

Canonical link: https://commits.webkit.org/268822@main
@webkit-commit-queue
Copy link
Collaborator

Committed 268822@main (ee2c346): https://commits.webkit.org/268822@main

Reviewed commits have been landed. Closing PR #18597 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ee2c346 into WebKit:main Oct 4, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanbaradlay alanbaradlay alanbaradlay approved these changes

@darinadler darinadler Awaiting requested review from darinadler

@rniwa rniwa Awaiting requested review from rniwa

Assignees

@cdumez cdumez

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
4 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @alanbaradlay