Make FloatRect etc. constexpr and adopt nanRect to make it usable for "not-filled" FloatRect purpose #18633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
Platform
|
EWS run on current version of this PR (hash a18d0cb)
|
Constellation
added
the
unsafe-merge-queue
… "not-filled" FloatRect purpose https://bugs.webkit.org/show_bug.cgi?id=262636 rdar://116476334 Reviewed by Justin Michaud and Mark Lam. Use constexpr in FloatRect and related classes, and add `nanRect` concept to make it usable for "not-filled" FloatRect. This is useful in subsequent SVG optimization instead of using `std::optional<FloatRect>`. * Source/WebCore/platform/graphics/FloatPoint.h: (WebCore::FloatPoint::FloatPoint): (WebCore::FloatPoint::zero): (WebCore::FloatPoint::isZero const): (WebCore::FloatPoint::x const): (WebCore::FloatPoint::y const): (WebCore::FloatPoint::scaled const): (WebCore::FloatPoint::dot const): (WebCore::FloatPoint::lengthSquared const): (WebCore::FloatPoint::shrunkTo const): (WebCore::FloatPoint::expandedTo const): (WebCore::FloatPoint::transposedPoint const): (WebCore::operator+): (WebCore::operator-): (WebCore::operator*): (WebCore::FloatPoint::rotate): * Source/WebCore/platform/graphics/FloatRect.h: (WebCore::FloatRect::FloatRect): (WebCore::FloatRect::location const): (WebCore::FloatRect::size const): (WebCore::FloatRect::x const): (WebCore::FloatRect::y const): (WebCore::FloatRect::maxX const): (WebCore::FloatRect::maxY const): (WebCore::FloatRect::width const): (WebCore::FloatRect::height const): (WebCore::FloatRect::area const): (WebCore::FloatRect::isEmpty const): (WebCore::FloatRect::isZero const): (WebCore::FloatRect::center const): (WebCore::FloatRect::minXMinYCorner const): (WebCore::FloatRect::maxXMinYCorner const): (WebCore::FloatRect::minXMaxYCorner const): (WebCore::FloatRect::maxXMaxYCorner const): (WebCore::FloatRect::contains const): (WebCore::FloatRect::overlapsYRange const): (WebCore::FloatRect::overlapsXRange const): (WebCore::FloatRect::transposedRect const): (WebCore::operator+): (WebCore::FloatRect::infiniteRect): (WebCore::FloatRect::isInfinite const): (WebCore::FloatRect::smallestRect): (WebCore::FloatRect::isSmallest const): (WebCore::FloatRect::nanRect): (WebCore::FloatRect::isNaN const): * Source/WebCore/platform/graphics/FloatSize.cpp: (WebCore::FloatSize::isZero const): Deleted. * Source/WebCore/platform/graphics/FloatSize.h: (WebCore::FloatSize::isZero const): * Tools/TestWebKitAPI/Tests/WebCore/FloatRectTests.cpp: (TestWebKitAPI::TEST): * Tools/TestWebKitAPI/Tests/WebCore/cg/DisplayListTestsCG.cpp: (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/268866@main
webkit-commit-queue
force-pushed
the
eng/Make-FloatRect-etc--constexpr-and-adopt-nanRect-to-make-it-usable-for-not-filled-FloatRect-purpose
branch
from
a18d0cb
to
4f828af
Compare
|
Committed 268866@main (4f828af): https://commits.webkit.org/268866@main Reviewed commits have been landed. Closing PR #18633 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4f828af
a18d0cb
🧪 wpe-wk2🧪 gtk-wk2🧪 api-gtk🛠 tv🧪 mac-AS-debug-wk2🛠 watch