Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make GraphicsContextState use generated serialization #18650

Conversation

pascoej
Copy link
Member

@pascoej pascoej commented Oct 4, 2023

ab4ed2e

Make GraphicsContextState use generated serialization
https://bugs.webkit.org/show_bug.cgi?id=262656
rdar://116488200

Reviewed by Ryosuke Niwa.

This patch starts to use generated serialization for GrahpicsContextState instead
of manually specifying ::encode and ::decode. There may have been a performance optimization
in the previous manually written encode, decode. If this is still required, we should generate
this serializer and create an option to replicate the optimization later.

* Source/WebCore/platform/graphics/GraphicsContextState.h:
(WebCore::GraphicsContextState::encode const): Deleted.
(WebCore::GraphicsContextState::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/268938@main

6a7bd26

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
  πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim
βœ… πŸ›  πŸ§ͺ merge   πŸ›  watch
βœ… πŸ›  watch-sim

@pascoej pascoej self-assigned this Oct 4, 2023
@pascoej pascoej added the WebKit2 Bugs relating to the WebKit2 API layer label Oct 4, 2023
@pascoej pascoej force-pushed the eng/Make-GraphicsContextState-use-generated-serialization branch from 3a4325b to 6a7bd26 Compare October 5, 2023 18:09
@pascoej pascoej added the merge-queue Applied to send a pull request to merge-queue label Oct 5, 2023
https://bugs.webkit.org/show_bug.cgi?id=262656
rdar://116488200

Reviewed by Ryosuke Niwa.

This patch starts to use generated serialization for GrahpicsContextState instead
of manually specifying ::encode and ::decode. There may have been a performance optimization
in the previous manually written encode, decode. If this is still required, we should generate
this serializer and create an option to replicate the optimization later.

* Source/WebCore/platform/graphics/GraphicsContextState.h:
(WebCore::GraphicsContextState::encode const): Deleted.
(WebCore::GraphicsContextState::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/268938@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Make-GraphicsContextState-use-generated-serialization branch from 6a7bd26 to ab4ed2e Compare October 5, 2023 20:31
@webkit-commit-queue
Copy link
Collaborator

Committed 268938@main (ab4ed2e): https://commits.webkit.org/268938@main

Reviewed commits have been landed. Closing PR #18650 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ab4ed2e into WebKit:main Oct 5, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
4 participants