-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port MockMediaDevice & related to the new IPC serialization format #18686
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
gavin-apple:eng/Port-MockMediaDevice--related-to-the-new-IPC-serialization-format
Oct 5, 2023
Merged
Port MockMediaDevice & related to the new IPC serialization format #18686
webkit-commit-queue
merged 1 commit into
WebKit:main
from
gavin-apple:eng/Port-MockMediaDevice--related-to-the-new-IPC-serialization-format
Oct 5, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gavin-apple
added
the
WebKit Process Model
Bugs related to WebKit's multi-process architecture
label
Oct 5, 2023
gavin-apple
force-pushed
the
eng/Port-MockMediaDevice--related-to-the-new-IPC-serialization-format
branch
from
October 5, 2023 12:35
5444b4f
to
90e4b41
Compare
EWS run on previous version of this PR (hash 90e4b41) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Oct 5, 2023
gavin-apple
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Oct 5, 2023
gavin-apple
force-pushed
the
eng/Port-MockMediaDevice--related-to-the-new-IPC-serialization-format
branch
from
October 5, 2023 13:18
90e4b41
to
4853488
Compare
EWS run on current version of this PR (hash 4853488) |
achristensen07
approved these changes
Oct 5, 2023
achristensen07
approved these changes
Oct 5, 2023
achristensen07
added
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Oct 5, 2023
https://bugs.webkit.org/show_bug.cgi?id=262692 rdar://116518406 Reviewed by Alex Christensen. Port MockMediaDevice & related to the new IPC serialization format. This includes: - MockMicrophoneProperties - MockSpeakerProperties - MockCameraProperties - MockDisplayProperties - MockMediaDevice::Flag - MockMediaDevice * Source/WebCore/platform/mock/MockMediaDevice.h: (WebCore::MockMediaDevice::captureDevice const): (WebCore::MockMicrophoneProperties::encode const): Deleted. (WebCore::MockMicrophoneProperties::decode): Deleted. (WebCore::MockSpeakerProperties::encode const): Deleted. (WebCore::MockSpeakerProperties::decode): Deleted. (WebCore::MockCameraProperties::encode const): Deleted. (WebCore::MockCameraProperties::decode): Deleted. (WebCore::MockDisplayProperties::encode const): Deleted. (WebCore::MockDisplayProperties::decode): Deleted. (WebCore::MockMediaDevice::encode const): Deleted. (WebCore::MockMediaDevice::decodeMockMediaDevice): Deleted. (WebCore::MockMediaDevice::decode): Deleted. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/268917@main
webkit-commit-queue
force-pushed
the
eng/Port-MockMediaDevice--related-to-the-new-IPC-serialization-format
branch
from
October 5, 2023 16:07
4853488
to
ced8381
Compare
Committed 268917@main (ced8381): https://commits.webkit.org/268917@main Reviewed commits have been landed. Closing PR #18686 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Applied to send a pull request to merge-queue, but skip building and testing
label
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ced8381
4853488
π§ͺ wpe-wk2