Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port MockMediaDevice & related to the new IPC serialization format #18686

Conversation

gavin-apple
Copy link
Contributor

@gavin-apple gavin-apple commented Oct 5, 2023

ced8381

Port MockMediaDevice & related to the new IPC serialization format
https://bugs.webkit.org/show_bug.cgi?id=262692
rdar://116518406

Reviewed by Alex Christensen.

Port MockMediaDevice & related to the new IPC serialization format. This
includes:
    - MockMicrophoneProperties
    - MockSpeakerProperties
    - MockCameraProperties
    - MockDisplayProperties
    - MockMediaDevice::Flag
    - MockMediaDevice

* Source/WebCore/platform/mock/MockMediaDevice.h:
(WebCore::MockMediaDevice::captureDevice const):
(WebCore::MockMicrophoneProperties::encode const): Deleted.
(WebCore::MockMicrophoneProperties::decode): Deleted.
(WebCore::MockSpeakerProperties::encode const): Deleted.
(WebCore::MockSpeakerProperties::decode): Deleted.
(WebCore::MockCameraProperties::encode const): Deleted.
(WebCore::MockCameraProperties::decode): Deleted.
(WebCore::MockDisplayProperties::encode const): Deleted.
(WebCore::MockDisplayProperties::decode): Deleted.
(WebCore::MockMediaDevice::encode const): Deleted.
(WebCore::MockMediaDevice::decodeMockMediaDevice): Deleted.
(WebCore::MockMediaDevice::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/268917@main

4853488

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
βœ… πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch
βœ… πŸ›  πŸ§ͺ unsafe-merge βœ… πŸ›  watch-sim

@gavin-apple gavin-apple self-assigned this Oct 5, 2023
@gavin-apple gavin-apple added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Oct 5, 2023
@gavin-apple gavin-apple force-pushed the eng/Port-MockMediaDevice--related-to-the-new-IPC-serialization-format branch from 5444b4f to 90e4b41 Compare October 5, 2023 12:35
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 5, 2023
@gavin-apple gavin-apple removed the merging-blocked Applied to prevent a change from being merged label Oct 5, 2023
@gavin-apple gavin-apple force-pushed the eng/Port-MockMediaDevice--related-to-the-new-IPC-serialization-format branch from 90e4b41 to 4853488 Compare October 5, 2023 13:18
@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 5, 2023
https://bugs.webkit.org/show_bug.cgi?id=262692
rdar://116518406

Reviewed by Alex Christensen.

Port MockMediaDevice & related to the new IPC serialization format. This
includes:
    - MockMicrophoneProperties
    - MockSpeakerProperties
    - MockCameraProperties
    - MockDisplayProperties
    - MockMediaDevice::Flag
    - MockMediaDevice

* Source/WebCore/platform/mock/MockMediaDevice.h:
(WebCore::MockMediaDevice::captureDevice const):
(WebCore::MockMicrophoneProperties::encode const): Deleted.
(WebCore::MockMicrophoneProperties::decode): Deleted.
(WebCore::MockSpeakerProperties::encode const): Deleted.
(WebCore::MockSpeakerProperties::decode): Deleted.
(WebCore::MockCameraProperties::encode const): Deleted.
(WebCore::MockCameraProperties::decode): Deleted.
(WebCore::MockDisplayProperties::encode const): Deleted.
(WebCore::MockDisplayProperties::decode): Deleted.
(WebCore::MockMediaDevice::encode const): Deleted.
(WebCore::MockMediaDevice::decodeMockMediaDevice): Deleted.
(WebCore::MockMediaDevice::decode): Deleted.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/268917@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Port-MockMediaDevice--related-to-the-new-IPC-serialization-format branch from 4853488 to ced8381 Compare October 5, 2023 16:07
@webkit-commit-queue
Copy link
Collaborator

Committed 268917@main (ced8381): https://commits.webkit.org/268917@main

Reviewed commits have been landed. Closing PR #18686 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ced8381 into WebKit:main Oct 5, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
5 participants