Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[git-webkit] Prompt user when GitHub credentials are likely incorrect #187

Merged
merged 0 commits into from Mar 8, 2022
Merged

[git-webkit] Prompt user when GitHub credentials are likely incorrect #187

merged 0 commits into from Mar 8, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Mar 3, 2022 •
edited

b360ddd

[git-webkit] Prompt user when GitHub credentials are likely incorrect
https://bugs.webkit.org/show_bug.cgi?id=237450
<rdar://problem/89781069 >

Reviewed by Dewei Zhu.

GitHub doesn't make it obvious when credentials are invalid, but our scripts
can make an educated guess when invalid credentials are the root cause.

* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/github.py:
(Tracker): Add REFRESH_TOKEN_PROMPT.
* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py:
(GitHub.PRGenerator.create):
(GitHub.PRGenerator.update):
(GitHub.request):
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/checkout_unittest.py:
(TestCheckout.test_no_pr_github):


Canonical link: https://commits.webkit.org/248188@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Mar 3, 2022
@facetothefate
Copy link
Member

r+ but need a rubber stamp

@JonWBedard JonWBedard added merge-queue Applied to send a pull request to merge-queue and removed merge-queue Applied to send a pull request to merge-queue labels Mar 8, 2022
dewei-zhu
dewei-zhu approved these changes Mar 8, 2022
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@JonWBedard JonWBedard merged commit b360ddd into WebKit:main Mar 8, 2022
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/248188@main (b360ddd)!

@JonWBedard JonWBedard force-pushed the eng/git-webkit-Prompt-user-when-GitHub-credentials-are-likely-incorrect branch from 67e11d8 to b360ddd Compare March 8, 2022 22:18
@JonWBedard JonWBedard deleted the eng/git-webkit-Prompt-user-when-GitHub-credentials-are-likely-incorrect branch March 8, 2022 22:28
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

@facetothefate facetothefate Awaiting requested review from facetothefate

@sundiamonde sundiamonde Awaiting requested review from sundiamonde

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@JonWBedard @facetothefate @dewei-zhu