Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some unused "slowPath" arguments in LLInt asm macros. #18709

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Remove some unused "slowPath" arguments in LLInt asm macros. #18709

merged 1 commit into from
Oct 6, 2023

Conversation

MenloDorian
Copy link

@MenloDorian MenloDorian commented Oct 5, 2023 •
edited by webkit-early-warning-system
Loading

85cc8f5

Remove some unused "slowPath" arguments in LLInt asm macros.
https://bugs.webkit.org/show_bug.cgi?id=262717
rdar://116537174

Reviewed by Alexey Shvayka.

Just removing some obsolete dead code.

* Source/JavaScriptCore/llint/LowLevelInterpreter.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:

Canonical link: https://commits.webkit.org/268963@main

75f7232

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@MenloDorian MenloDorian requested a review from a team as a code owner October 5, 2023 19:43
@MenloDorian MenloDorian self-assigned this Oct 5, 2023
@MenloDorian MenloDorian added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Oct 5, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 5, 2023 •
edited
Loading

EWS run on current version of this PR (hash 75f7232)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 tv-sim ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch ✅ 🛠 jsc-mips
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@MenloDorian MenloDorian added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 6, 2023
Remove some unused "slowPath" arguments in LLInt asm macros.
85cc8f5 
https://bugs.webkit.org/show_bug.cgi?id=262717
rdar://116537174

Reviewed by Alexey Shvayka.

Just removing some obsolete dead code.

* Source/JavaScriptCore/llint/LowLevelInterpreter.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm:
* Source/JavaScriptCore/llint/LowLevelInterpreter64.asm:

Canonical link: https://commits.webkit.org/268963@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Remove-some-unused-slowPath-arguments-in-LLInt-asm-macros- branch from 75f7232 to 85cc8f5 Compare October 6, 2023 03:14
@webkit-commit-queue
Copy link
Collaborator

Committed 268963@main (85cc8f5): https://commits.webkit.org/268963@main

Reviewed commits have been landed. Closing PR #18709 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 85cc8f5 into WebKit:main Oct 6, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 6, 2023
@MenloDorian MenloDorian deleted the eng/Remove-some-unused-slowPath-arguments-in-LLInt-asm-macros- branch October 16, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shvaikalesh shvaikalesh shvaikalesh approved these changes

Assignees

@MenloDorian MenloDorian

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@MenloDorian @webkit-early-warning-system @webkit-commit-queue @shvaikalesh