[run-benchmark] Avoid race condition when killing the browser subprocess on Linux #1874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperezdc
approved these changes
Jun 28, 2022
…ess on Linux https://bugs.webkit.org/show_bug.cgi?id=242083 Reviewed by Adrian Perez de Castro. Fix a race condition that happens when the run-benchmark runner attempts to close the browser (on Linux). Sometimes the browser subprocess ends in the interval between the is_running() check and the kill() call, causing an exception on the runner. * Tools/Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py: (LinuxBrowserDriver.close_browsers): Canonical link: https://commits.webkit.org/251936@main
webkit-early-warning-system
force-pushed
the
bug-242083
branch
from
4437248
to
7fd0981
Compare
|
Committed 251936@main (7fd0981): https://commits.webkit.org/251936@main Reviewed commits have been landed. Closing PR #1874 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7fd0981