Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tvOS] Enable AVKit fullscreen at build time #18778

Conversation

aestes
Copy link
Contributor

@aestes aestes commented Oct 6, 2023

193f3e7

[tvOS] Enable AVKit fullscreen at build time
https://bugs.webkit.org/show_bug.cgi?id=262803
rdar://116592441

Reviewed by Jer Noble.

Set ENABLE_VIDEO_PRESENTATION_MODE and HAVE_AVKIT to 1 on tvOS. Added declarations and platform
ifdefs so that VideoFullscreenInterfaceAVKit builds on tvOS.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:
* Source/WebCore/platform/cocoa/WebAVPlayerLayerView.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerViewController initWithFullscreenInterface:]):
(-[WebAVPlayerViewController enterFullScreenAnimated:completionHandler:]):
(-[WebAVPlayerViewController exitFullScreenAnimated:completionHandler:]):
(-[WebAVPlayerViewController MY_NO_RETURN]):
(-[WebAVPlayerViewController isPictureInPicturePossible]):
(-[WebAVPlayerViewController isPictureInPictureActive]):
(-[WebAVPlayerViewController pictureInPictureActive]):
(-[WebAVPlayerViewController pictureInPictureWasStartedWhenEnteringBackground]):
(VideoFullscreenInterfaceAVKit::setPlayerIdentifier):

Canonical link: https://commits.webkit.org/269030@main

a7b8fee

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe   πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
  πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
  πŸ›  πŸ§ͺ jsc βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
  πŸ›  πŸ§ͺ jsc-arm64   πŸ›  tv   πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  tv-sim βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  πŸ§ͺ merge   πŸ›  watch βœ… πŸ›  jsc-mips
βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@aestes aestes self-assigned this Oct 6, 2023
@aestes aestes added the Media Bugs related to the HTML 5 Media elements. label Oct 6, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 6, 2023
@aestes aestes removed the merging-blocked Applied to prevent a change from being merged label Oct 6, 2023
@aestes aestes force-pushed the eng/tvOS-Enable-AVKit-fullscreen-at-build-time branch from 2f98904 to c0d58db Compare October 6, 2023 23:00
@aestes aestes force-pushed the eng/tvOS-Enable-AVKit-fullscreen-at-build-time branch from c0d58db to 3e6575a Compare October 6, 2023 23:46
@aestes aestes force-pushed the eng/tvOS-Enable-AVKit-fullscreen-at-build-time branch from 3e6575a to a7b8fee Compare October 7, 2023 00:35
@aestes aestes added the merge-queue Applied to send a pull request to merge-queue label Oct 7, 2023
https://bugs.webkit.org/show_bug.cgi?id=262803
rdar://116592441

Reviewed by Jer Noble.

Set ENABLE_VIDEO_PRESENTATION_MODE and HAVE_AVKIT to 1 on tvOS. Added declarations and platform
ifdefs so that VideoFullscreenInterfaceAVKit builds on tvOS.

* Source/WTF/wtf/PlatformEnableCocoa.h:
* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h:
* Source/WebCore/platform/cocoa/WebAVPlayerLayerView.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h:
* Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerViewController initWithFullscreenInterface:]):
(-[WebAVPlayerViewController enterFullScreenAnimated:completionHandler:]):
(-[WebAVPlayerViewController exitFullScreenAnimated:completionHandler:]):
(-[WebAVPlayerViewController MY_NO_RETURN]):
(-[WebAVPlayerViewController isPictureInPicturePossible]):
(-[WebAVPlayerViewController isPictureInPictureActive]):
(-[WebAVPlayerViewController pictureInPictureActive]):
(-[WebAVPlayerViewController pictureInPictureWasStartedWhenEnteringBackground]):
(VideoFullscreenInterfaceAVKit::setPlayerIdentifier):

Canonical link: https://commits.webkit.org/269030@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/tvOS-Enable-AVKit-fullscreen-at-build-time branch from a7b8fee to 193f3e7 Compare October 7, 2023 03:01
@webkit-commit-queue
Copy link
Collaborator

Committed 269030@main (193f3e7): https://commits.webkit.org/269030@main

Reviewed commits have been landed. Closing PR #18778 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 7, 2023
@webkit-commit-queue webkit-commit-queue merged commit 193f3e7 into WebKit:main Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
5 participants