-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tvOS] Enable AVKit fullscreen at build time #18778
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
aestes:eng/tvOS-Enable-AVKit-fullscreen-at-build-time
Oct 7, 2023
Merged
[tvOS] Enable AVKit fullscreen at build time #18778
webkit-commit-queue
merged 1 commit into
WebKit:main
from
aestes:eng/tvOS-Enable-AVKit-fullscreen-at-build-time
Oct 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EWS run on previous version of this PR (hash 2f98904) |
jernoble
approved these changes
Oct 6, 2023
2f98904
to
c0d58db
Compare
EWS run on previous version of this PR (hash c0d58db) |
c0d58db
to
3e6575a
Compare
EWS run on previous version of this PR (hash 3e6575a) |
3e6575a
to
a7b8fee
Compare
https://bugs.webkit.org/show_bug.cgi?id=262803 rdar://116592441 Reviewed by Jer Noble. Set ENABLE_VIDEO_PRESENTATION_MODE and HAVE_AVKIT to 1 on tvOS. Added declarations and platform ifdefs so that VideoFullscreenInterfaceAVKit builds on tvOS. * Source/WTF/wtf/PlatformEnableCocoa.h: * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/PAL/pal/spi/cocoa/AVKitSPI.h: * Source/WebCore/platform/cocoa/WebAVPlayerLayerView.h: * Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.h: * Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm: (-[WebAVPlayerViewController initWithFullscreenInterface:]): (-[WebAVPlayerViewController enterFullScreenAnimated:completionHandler:]): (-[WebAVPlayerViewController exitFullScreenAnimated:completionHandler:]): (-[WebAVPlayerViewController MY_NO_RETURN]): (-[WebAVPlayerViewController isPictureInPicturePossible]): (-[WebAVPlayerViewController isPictureInPictureActive]): (-[WebAVPlayerViewController pictureInPictureActive]): (-[WebAVPlayerViewController pictureInPictureWasStartedWhenEnteringBackground]): (VideoFullscreenInterfaceAVKit::setPlayerIdentifier): Canonical link: https://commits.webkit.org/269030@main
a7b8fee
to
193f3e7
Compare
Committed 269030@main (193f3e7): https://commits.webkit.org/269030@main Reviewed commits have been landed. Closing PR #18778 and removing active labels. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
193f3e7
a7b8fee
π wincairoπ§ͺ wpe-wk2π§ͺ ios-wk2-wptπ§ͺ gtk-wk2π π§ͺ jscπ π§ͺ jsc-arm64π tvπ§ͺ mac-AS-debug-wk2π watch