Use Vector::uncheckedAppend() less in WebCore #18804

cdumez · 2023-10-07T04:07:58Z

`ba50d1b`

Use Vector::uncheckedAppend() less in WebCore
https://bugs.webkit.org/show_bug.cgi?id=262832

Reviewed by Darin Adler.

Use Vector::uncheckedAppend() less in WebCore and use more efficient alternatives
now that uncheckedAppend() has become an alias for append().

* Source/WebCore/Modules/streams/ReadableStream.cpp:
(WebCore::ReadableStream::tee):
* Source/WebCore/Modules/webxr/WebXRHand.cpp:
(WebCore::WebXRHand::WebXRHand):
* Source/WebCore/PAL/pal/avfoundation/OutputContext.mm:
(PAL::OutputContext::outputDevices const):
* Source/WebCore/accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::objectsForIDs const):
* Source/WebCore/accessibility/AccessibilityNodeObject.cpp:
(WebCore::labelsForNode):
(WebCore::labelForNode):
(WebCore::AccessibilityNodeObject::checkboxOrRadioRect const):
(WebCore::AccessibilityNodeObject::correspondingLabelForControlElement const):
(WebCore::AccessibilityNodeObject::textForLabelElements const):
(WebCore::AccessibilityNodeObject::titleUIElement const):
(): Deleted.
* Source/WebCore/accessibility/AccessibilityNodeObject.h:
* Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:
(WebCore::AXIsolatedObject::children):
* Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp:
(WebCore::AXIsolatedTree::resolveAppends):
* Source/WebCore/animation/CSSPropertyAnimation.cpp:
(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):
* Source/WebCore/contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::addUniversalActionsToDFA):
* Source/WebCore/contentextensions/DFAMinimizer.cpp:
(WebCore::ContentExtensions::DFAMinimizer::minimize):
* Source/WebCore/contentextensions/DFANode.cpp:
(WebCore::ContentExtensions::DFANode::actions const):
* Source/WebCore/css/CSSValueList.cpp:
(WebCore::CSSValueContainingVector::copyValues const):
* Source/WebCore/css/CSSVariableData.cpp:
(WebCore::CSSVariableData::CSSVariableData):
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::ComputedStyleExtractor::copyProperties const):
* Source/WebCore/css/StyleProperties.cpp:
(WebCore::StyleProperties::copyProperties const):
* Source/WebCore/css/parser/CSSParserTokenRange.h:
(WebCore::CSSParserTokenRange::size const):
* Source/WebCore/css/typedom/HashMapStylePropertyMapReadOnly.cpp:
(WebCore::HashMapStylePropertyMapReadOnly::entries const):
* Source/WebCore/css/typedom/StylePropertyMapReadOnly.cpp:
(WebCore::StylePropertyMapReadOnly::reifyValueToVector):
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthLastChild):
* Source/WebCore/dom/ComposedTreeIterator.h:
(WebCore::ComposedTreeIterator::ComposedTreeIterator):
* Source/WebCore/dom/Element.cpp:
(WebCore::Element::getAttributeNames const):
* Source/WebCore/dom/ElementData.h:
(WebCore::AttributeConstIterator::operator--):
(WebCore::AttributeIteratorAccessor::size const):
* Source/WebCore/dom/ImageOverlay.cpp:
(WebCore::ImageOverlay::updateWithTextRecognitionResult):
* Source/WebCore/dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::SelectorDataList):
* Source/WebCore/dom/TouchList.h:
(WebCore::TouchList::TouchList):
* Source/WebCore/html/FileInputType.cpp:
(WebCore::FileInputType::filesChosen):
* Source/WebCore/html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::textFieldValues const):
* Source/WebCore/html/LinkIconCollector.cpp:
(WebCore::LinkIconCollector::iconsOfTypes):
* Source/WebCore/loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setActiveContentRuleListActionPatterns):
* Source/WebCore/loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::didAddClient):
* Source/WebCore/page/Page.cpp:
(WebCore::Page::replaceRangesWithText):
* Source/WebCore/page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::buildSelectionHighlight):
* Source/WebCore/platform/FileChooser.cpp:
(WebCore::FileChooser::chooseFiles):
* Source/WebCore/platform/SharedBuffer.cpp:
(WebCore::FragmentedSharedBuffer::copy const):
* Source/WebCore/platform/animation/AcceleratedEffectValues.cpp:
(WebCore::AcceleratedEffectValues::AcceleratedEffectValues):
* Source/WebCore/platform/audio/AudioBus.cpp:
(WebCore::AudioBus::AudioBus):
* Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp:
(WebCore::AudioDSPKernelProcessor::initialize):
* Source/WebCore/platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::AudioResampler):
* Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::setNumberOfChannels):
* Source/WebCore/platform/audio/MultiChannelResampler.cpp:
(WebCore::MultiChannelResampler::MultiChannelResampler):
* Source/WebCore/platform/graphics/ComplexTextController.cpp:
(WebCore::ComplexTextController::finishConstruction):
* Source/WebCore/platform/graphics/FontCache.cpp:
(WebCore::FontCache::purgeInactiveFontData):
* Source/WebCore/platform/graphics/FontCascade.cpp:
(WebCore::FontCascade::characterSelectionRectsForText const):
* Source/WebCore/platform/graphics/FontCascadeCache.cpp:
(WebCore::makeFontCascadeCacheKey):
* Source/WebCore/platform/graphics/GraphicsLayer.h:
(WebCore::KeyframeValueList::KeyframeValueList):
* Source/WebCore/platform/graphics/PathUtilities.cpp:
(WebCore::PathUtilities::pathsWithShrinkWrappedRects):
* Source/WebCore/platform/graphics/SourceBufferPrivate.cpp:
(WebCore::SourceBufferPrivate::trackBuffersRanges const):
* Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:
(WebCore::extractSinfData):
* Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::copyKeyStatuses const):

Canonical link: https://commits.webkit.org/269062@main

19c226b

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-07T04:08:10Z

EWS run on previous version of this PR (hash 364f14c)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	✅ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-07T20:36:00Z

EWS run on previous version of this PR (hash fd2cd45)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	❌ 🧪 gtk-wk2
	~~🧪 api-ios~~	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-07T22:09:54Z

EWS run on previous version of this PR (hash df6ba51)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

darinadler · 2023-10-08T22:26:43Z

Source/WebCore/contentextensions/ContentExtensionCompiler.cpp

@@ -182,8 +182,7 @@ static void addUniversalActionsToDFA(DFA& dfa, UniversalActionSet&& universalAct
    ASSERT(!root.actionsLength());
    unsigned actionsStart = dfa.actions.size();
    dfa.actions.reserveCapacity(dfa.actions.size() + universalActions.size());
-    for (uint64_t action : universalActions)
-        dfa.actions.uncheckedAppend(action);
+    dfa.actions.appendRange(universalActions.begin(), universalActions.end());


Do we benefit from doing reserveCapacity before appendRange?

At the moment, yes. However, I think we should consider optimizing Vector::appendRange() and reserve capacity at least when the input iterators are random access iterators (and std::distance() can return the size in constant time). I can look into this but likely in a follow-up.

Following up in #18839.

darinadler · 2023-10-08T22:28:45Z

Source/WebCore/css/CSSValueList.cpp

-    for (auto& value : *this)
-        builder.uncheckedAppend(const_cast<CSSValue&>(value));
-    return builder;
+    return WTF::map<4>(*this, [](auto& value) -> Ref<CSSValue> {


The idea is that CSSValueListBuilder could change its inline capacity in the future. The hardcoded 4 here doesn’t seem great, especially if it will make working but inefficient code in case of mismatch. I suppose it’s OK if compilation will just fail.

It fails to build at the moment:

Source/WebCore/css/CSSValueList.cpp:214:12: error: no viable conversion from returned value of type 'Vector<[...], 0UL aka 0, [2 * ...]>' to function return type 'Vector<[...], 4, [2 * ...]>'

That said, it is probably better to use a global constant to be safe. Nothing stops someones from updating the Vector class to convert silently.

darinadler · 2023-10-08T22:31:14Z

Source/WebCore/dom/ImageOverlay.cpp

-        auto& block = result.blocks[index];
+
+    size_t index = 0;
+    Vector<FontSizeAdjustmentState> elementsToAdjust = WTF::compactMap(result.blocks, [&](auto& block) -> std::optional<FontSizeAdjustmentState> {


darinadler · 2023-10-08T22:32:01Z

Source/WebCore/loader/DocumentLoader.cpp

-        Vector<UserContentURLPattern> patternVector;
-        patternVector.reserveInitialCapacity(pair.value.size());
-        for (auto& patternString : pair.value) {
+        Vector<UserContentURLPattern> patternVector = WTF::compactMap(pair.value, [](auto& patternString) -> std::optional<UserContentURLPattern> {


darinadler · 2023-10-08T22:32:30Z

Source/WebCore/page/mac/ServicesOverlayController.mm

-        cgRects.reserveInitialCapacity(m_currentSelectionRects.size());
-
-        for (auto& rect : m_currentSelectionRects) {
+        Vector<CGRect> cgRects = WTF::map(m_currentSelectionRects, [&](auto& rect) -> CGRect {


webkit-early-warning-system · 2023-10-08T23:51:20Z

EWS run on current version of this PR (hash 19c226b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	~~🧪 wpe-wk2~~
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	~~🧪 mac-AS-debug-wk2~~
	✅ 🛠 tv-sim
✅ 🛠 🧪 merge	✅ 🛠 watch
	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=262832 Reviewed by Darin Adler. Use Vector::uncheckedAppend() less in WebCore and use more efficient alternatives now that uncheckedAppend() has become an alias for append(). * Source/WebCore/Modules/streams/ReadableStream.cpp: (WebCore::ReadableStream::tee): * Source/WebCore/Modules/webxr/WebXRHand.cpp: (WebCore::WebXRHand::WebXRHand): * Source/WebCore/PAL/pal/avfoundation/OutputContext.mm: (PAL::OutputContext::outputDevices const): * Source/WebCore/accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::objectsForIDs const): * Source/WebCore/accessibility/AccessibilityNodeObject.cpp: (WebCore::labelsForNode): (WebCore::labelForNode): (WebCore::AccessibilityNodeObject::checkboxOrRadioRect const): (WebCore::AccessibilityNodeObject::correspondingLabelForControlElement const): (WebCore::AccessibilityNodeObject::textForLabelElements const): (WebCore::AccessibilityNodeObject::titleUIElement const): (): Deleted. * Source/WebCore/accessibility/AccessibilityNodeObject.h: * Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp: (WebCore::AXIsolatedObject::children): * Source/WebCore/accessibility/isolatedtree/AXIsolatedTree.cpp: (WebCore::AXIsolatedTree::resolveAppends): * Source/WebCore/animation/CSSPropertyAnimation.cpp: (WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap): * Source/WebCore/contentextensions/ContentExtensionCompiler.cpp: (WebCore::ContentExtensions::addUniversalActionsToDFA): * Source/WebCore/contentextensions/DFAMinimizer.cpp: (WebCore::ContentExtensions::DFAMinimizer::minimize): * Source/WebCore/contentextensions/DFANode.cpp: (WebCore::ContentExtensions::DFANode::actions const): * Source/WebCore/css/CSSValueList.cpp: (WebCore::CSSValueContainingVector::copyValues const): * Source/WebCore/css/CSSVariableData.cpp: (WebCore::CSSVariableData::CSSVariableData): * Source/WebCore/css/ComputedStyleExtractor.cpp: (WebCore::ComputedStyleExtractor::copyProperties const): * Source/WebCore/css/StyleProperties.cpp: (WebCore::StyleProperties::copyProperties const): * Source/WebCore/css/parser/CSSParserTokenRange.h: (WebCore::CSSParserTokenRange::size const): * Source/WebCore/css/typedom/HashMapStylePropertyMapReadOnly.cpp: (WebCore::HashMapStylePropertyMapReadOnly::entries const): * Source/WebCore/css/typedom/StylePropertyMapReadOnly.cpp: (WebCore::StylePropertyMapReadOnly::reifyValueToVector): * Source/WebCore/cssjit/SelectorCompiler.cpp: (WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild): (WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthLastChild): * Source/WebCore/dom/ComposedTreeIterator.h: (WebCore::ComposedTreeIterator::ComposedTreeIterator): * Source/WebCore/dom/Element.cpp: (WebCore::Element::getAttributeNames const): * Source/WebCore/dom/ElementData.h: (WebCore::AttributeConstIterator::operator--): (WebCore::AttributeIteratorAccessor::size const): * Source/WebCore/dom/ImageOverlay.cpp: (WebCore::ImageOverlay::updateWithTextRecognitionResult): * Source/WebCore/dom/SelectorQuery.cpp: (WebCore::SelectorDataList::SelectorDataList): * Source/WebCore/dom/TouchList.h: (WebCore::TouchList::TouchList): * Source/WebCore/html/FileInputType.cpp: (WebCore::FileInputType::filesChosen): * Source/WebCore/html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::textFieldValues const): * Source/WebCore/html/LinkIconCollector.cpp: (WebCore::LinkIconCollector::iconsOfTypes): * Source/WebCore/loader/DocumentLoader.cpp: (WebCore::DocumentLoader::setActiveContentRuleListActionPatterns): * Source/WebCore/loader/cache/CachedRawResource.cpp: (WebCore::CachedRawResource::didAddClient): * Source/WebCore/page/Page.cpp: (WebCore::Page::replaceRangesWithText): * Source/WebCore/page/mac/ServicesOverlayController.mm: (WebCore::ServicesOverlayController::buildSelectionHighlight): * Source/WebCore/platform/FileChooser.cpp: (WebCore::FileChooser::chooseFiles): * Source/WebCore/platform/SharedBuffer.cpp: (WebCore::FragmentedSharedBuffer::copy const): * Source/WebCore/platform/animation/AcceleratedEffectValues.cpp: (WebCore::AcceleratedEffectValues::AcceleratedEffectValues): * Source/WebCore/platform/audio/AudioBus.cpp: (WebCore::AudioBus::AudioBus): * Source/WebCore/platform/audio/AudioDSPKernelProcessor.cpp: (WebCore::AudioDSPKernelProcessor::initialize): * Source/WebCore/platform/audio/AudioResampler.cpp: (WebCore::AudioResampler::AudioResampler): * Source/WebCore/platform/audio/DynamicsCompressorKernel.cpp: (WebCore::DynamicsCompressorKernel::setNumberOfChannels): * Source/WebCore/platform/audio/MultiChannelResampler.cpp: (WebCore::MultiChannelResampler::MultiChannelResampler): * Source/WebCore/platform/graphics/ComplexTextController.cpp: (WebCore::ComplexTextController::finishConstruction): * Source/WebCore/platform/graphics/FontCache.cpp: (WebCore::FontCache::purgeInactiveFontData): * Source/WebCore/platform/graphics/FontCascade.cpp: (WebCore::FontCascade::characterSelectionRectsForText const): * Source/WebCore/platform/graphics/FontCascadeCache.cpp: (WebCore::makeFontCascadeCacheKey): * Source/WebCore/platform/graphics/GraphicsLayer.h: (WebCore::KeyframeValueList::KeyframeValueList): * Source/WebCore/platform/graphics/PathUtilities.cpp: (WebCore::PathUtilities::pathsWithShrinkWrappedRects): * Source/WebCore/platform/graphics/SourceBufferPrivate.cpp: (WebCore::SourceBufferPrivate::trackBuffersRanges const): * Source/WebCore/platform/graphics/avfoundation/CDMFairPlayStreaming.cpp: (WebCore::extractSinfData): * Source/WebCore/platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm: (WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::copyKeyStatuses const): Canonical link: https://commits.webkit.org/269062@main

webkit-commit-queue · 2023-10-09T00:57:00Z

Committed 269062@main (ba50d1b): https://commits.webkit.org/269062@main

Reviewed commits have been landed. Closing PR #18804 and removing active labels.

cdumez self-assigned this Oct 7, 2023

cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Oct 7, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 7, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 7, 2023

cdumez force-pushed the 262832_WebCore_less_uncheckedAppend branch from 364f14c to fd2cd45 Compare October 7, 2023 20:35

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 7, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 7, 2023

cdumez force-pushed the 262832_WebCore_less_uncheckedAppend branch from fd2cd45 to df6ba51 Compare October 7, 2023 22:08

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 7, 2023

cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 8, 2023

cdumez marked this pull request as ready for review October 8, 2023 03:05

cdumez requested review from b-weinstein, xeenon, graouts and rniwa as code owners October 8, 2023 03:05

cdumez requested review from darinadler, ddkilzer, rniwa, brentfulgham and achristensen07 and removed request for graouts, xeenon, rniwa and b-weinstein October 8, 2023 03:05

darinadler approved these changes Oct 8, 2023

View reviewed changes

cdumez force-pushed the 262832_WebCore_less_uncheckedAppend branch from df6ba51 to 19c226b Compare October 8, 2023 23:50

cdumez added the merge-queue Applied to send a pull request to merge-queue label Oct 8, 2023

webkit-commit-queue force-pushed the 262832_WebCore_less_uncheckedAppend branch from 19c226b to ba50d1b Compare October 9, 2023 00:56

webkit-commit-queue merged commit ba50d1b into WebKit:main Oct 9, 2023

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 9, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Vector::uncheckedAppend() less in WebCore #18804

Use Vector::uncheckedAppend() less in WebCore #18804

cdumez commented Oct 7, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

darinadler Oct 8, 2023

cdumez Oct 8, 2023

cdumez Oct 9, 2023

darinadler Oct 8, 2023 •

edited

Loading

cdumez Oct 8, 2023

darinadler Oct 8, 2023

darinadler Oct 8, 2023

darinadler Oct 8, 2023

webkit-early-warning-system commented Oct 8, 2023 •

edited

Loading

webkit-commit-queue commented Oct 9, 2023

Use Vector::uncheckedAppend() less in WebCore #18804

Use Vector::uncheckedAppend() less in WebCore #18804

Conversation

cdumez commented Oct 7, 2023 • edited by webkit-early-warning-system Loading

webkit-early-warning-system commented Oct 7, 2023 • edited Loading

webkit-early-warning-system commented Oct 7, 2023 • edited Loading

webkit-early-warning-system commented Oct 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

darinadler Oct 8, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Oct 8, 2023 • edited Loading

webkit-commit-queue commented Oct 9, 2023

cdumez commented Oct 7, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 7, 2023 •

edited

Loading

darinadler Oct 8, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 8, 2023 •

edited

Loading