New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to enter fullscreen in Counterstrike (http://game.play-cs.com) in Safari 16.3 #18883
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
aestes:eng/Unable-to-enter-fullscreen-in-Counterstrike-httpgame-play-cs-com-in-Safari-16-3
Oct 10, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aestes
added
the
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
label
Oct 10, 2023
EWS run on previous version of this PR (hash cc1ce21) |
aestes
force-pushed
the
eng/Unable-to-enter-fullscreen-in-Counterstrike-httpgame-play-cs-com-in-Safari-16-3
branch
from
October 10, 2023 15:39
cc1ce21
to
6891330
Compare
EWS run on current version of this PR (hash 6891330) |
jernoble
approved these changes
Oct 10, 2023
β¦ in Safari 16.3 https://bugs.webkit.org/show_bug.cgi?id=251648 rdar://104984915 Reviewed by Jer Noble. When entering fullscreen, WKFullScreenWindowController calls WebPageProxy::setSuppressVisibilityUpdates to suppress visibility updates while the web view moves to the new fullscreen window, since updating visibility is unnecessary when transitioning to fullscreen and can even cause bugs (see the comment in -[WKFullScreenWindowController enterFullScreen:]). It ends suppression in -beganEnterFullScreenWithInitialFrame:finalFrame: and schedules an activity state update, but this occurs at a time when AppKit considers the fullscreen window to be occluded. As a result a `visibilitychange` event is dispatched where `document.visibilityState == 'hidden'`, and play-cs.com responds to this event by exiting fullscreen. The upshot is that the user cannot stay in fullscreen as the page exits this mode as soon as the user enters it. Resolved this by extending the period where visibility updates are suppressed to when -finishedEnterFullScreenAnimation: is called. At this point AppKit no longer considers the fullscreen window to be occluded, so WebPageProxy detects no change in activity state and does not dispatch any `visibilitychange` events. This matches the behavior of Firefox and Chrome on macOS, which also do not dispatch `visiblitychange` events when entering fullscreen. Added an API test. * Source/WebKit/UIProcess/mac/WKFullScreenWindowController.mm: (-[WKFullScreenWindowController enterFullScreen:]): (-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]): (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): * Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.html: * Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm: (-[FullscreenDelegateMessageHandler userContentController:didReceiveScriptMessage:]): (TestWebKitAPI::TEST): Canonical link: https://commits.webkit.org/269150@main
webkit-commit-queue
force-pushed
the
eng/Unable-to-enter-fullscreen-in-Counterstrike-httpgame-play-cs-com-in-Safari-16-3
branch
from
October 10, 2023 17:11
6891330
to
7e8c765
Compare
Committed 269150@main (7e8c765): https://commits.webkit.org/269150@main Reviewed commits have been landed. Closing PR #18883 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Oct 10, 2023
aestes
deleted the
eng/Unable-to-enter-fullscreen-in-Counterstrike-httpgame-play-cs-com-in-Safari-16-3
branch
October 30, 2023 23:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
New Bugs
Unclassified bugs are placed in this component until the correct component can be determined.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7e8c765
6891330
π iosπ ios-simπ§ͺ wpe-wk2π§ͺ ios-wk2π§ͺ ios-wk2-wptπ§ͺ api-ios