The textarea element URL encodes pasteboard data

[rr-codes]

a222530

The textarea element URL encodes pasteboard data
https://bugs.webkit.org/show_bug.cgi?id=261936
rdar://116056298

Reviewed by Wenson Hsieh.

In iOS 17 and aligned OS versions, `+[NSURL URLWithString:]` now percent-encodes invalid characters
to help create a valid URL, where previously it would return `nil`.

As a result of this new behavior, strings are now made representable as URLs more easily, and so
their URL representations are added to the pasteboard with percent-encoded invalid characters.

Fix by using the new `+[NSURL URLWithString:encodingInvalidCharacters:]` method, which restores
pre-iOS 17 behavior.

* Source/WTF/wtf/PlatformHave.h:
* Source/WebCore/platform/ios/PlatformPasteboardIOS.mm:
(WebCore::addRepresentationsForPlainText):
* Tools/TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/269178@main

7626c09

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	🧪 api-mac	✅ 🛠 gtk
	🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	🛠 tv	🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 445969b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

[aproskuryakov]

Why do we try to create a URL when copying text from an input field?

[aproskuryakov]

Using "new" in feature names is an anti-pattern. It will be old in no time, with a very misleading name.

Something like HAVE_NSURL_ENCODING_INVALID_CHARACTERS would seem better.

[rr-codes]

Why do we try to create a URL when copying text from an input field?

When copying any text, we try to see if it is a valid URL and if so, copy the URL representation as well as the plain text representation to the pasteboard, so that it can be pasted as either of those two types.

[webkit-early-warning-system]

EWS run on current version of this PR (hash 7626c09)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	🧪 api-mac	✅ 🛠 gtk
	🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	🛠 tv	🧪 mac-AS-debug-wk2	✅ 🛠 jsc-armv7
	✅ 🛠 tv-sim		✅ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	🛠 watch		✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

[aproskuryakov]

I think that this restates what we do, but does not explain why. Would anything break if we just removed this code?

[rr-codes]

I think that this restates what we do, but does not explain why. Would anything break if we just removed this code?

Yes; pasting it into Notes for example would make it be a hyperlink currently, but wouldn't do so if I removed the code

[aproskuryakov]

It's not clear to me if automatically linkifying test from <textarea> is correct behavior. But I guess the more mysterious it is, the harder it is to change.

[webkit-commit-queue]

Committed 269178@main (a222530): https://commits.webkit.org/269178@main

Reviewed commits have been landed. Closing PR #18902 and removing active labels.