Begin using C++23 in WebKit #19053

achristensen07 · 2023-10-13T16:26:37Z

`619fc6b`

Begin using C++23 in WebKit
https://bugs.webkit.org/show_bug.cgi?id=263122
rdar://116922827

Reviewed by Yusuke Suzuki, Abrar Rahman Protyasha and Dan Glastonbury.

* CMakeLists.txt:
* Configurations/CommonBase.xcconfig:
* Source/JavaScriptCore/Configurations/Base.xcconfig:
* Source/JavaScriptCore/DerivedSources.make:
* Source/ThirdParty/ANGLE/Configurations/Base.xcconfig:
* Source/ThirdParty/gmock/Configurations/Base.xcconfig:
* Source/ThirdParty/gtest/xcode/Config/General.xcconfig:
* Source/ThirdParty/libwebrtc/CMakeLists.txt:
* Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig:
* Source/WTF/Configurations/Base.xcconfig:
* Source/WebCore/Configurations/Base.xcconfig:
* Source/WebCore/DerivedSources.make:
* Source/WebCore/PAL/Configurations/Base.xcconfig:
* Source/WebCore/PAL/ThirdParty/libavif/Configurations/Base.xcconfig:
* Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/Base.xcconfig:
* Source/WebGPU/Configurations/Base.xcconfig:
* Source/WebInspectorUI/Configurations/Base.xcconfig:
* Source/WebKit/Configurations/Base.xcconfig:
* Source/WebKit/DerivedSources.make:
* Source/WebKit/PlatformMac.cmake:
* Source/WebKitLegacy/PlatformMac.cmake:
* Source/WebKitLegacy/mac/Configurations/Base.xcconfig:
* Source/bmalloc/Configurations/Base.xcconfig:
* Source/bmalloc/libpas/CMakeLists.txt:
* Source/cmake/OptionsCommon.cmake:
* Source/cmake/WebKitCompilerFlags.cmake:
* Tools/DumpRenderTree/DerivedSources.make:
* Tools/DumpRenderTree/mac/Configurations/Base.xcconfig:
* Tools/MiniBrowser/Configurations/Base.xcconfig:
* Tools/MobileMiniBrowser/Configurations/Base.xcconfig:
* Tools/Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
* Tools/TestWebKitAPI/Configurations/Base.xcconfig:
* Tools/WebGPUPlayground/Configurations/Base.xcconfig:
* Tools/WebKitTestRunner/Configurations/Base.xcconfig:
* Tools/WebKitTestRunner/DerivedSources.make:
* Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig:

Canonical link: https://commits.webkit.org/280217@main

e30ecb3

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	⏳ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	⏳ 🧪 vision-wk2		~~🛠 jsc-armv7~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv		~~🧪 jsc-armv7-tests~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-13T16:26:54Z

EWS run on previous version of this PR (hash b062a4b)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	❌ 🛠 gtk
	❌ 🧪 ios-wk2-wpt	❌ 🧪 mac-wk1	❌ 🧪 gtk-wk2
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	❌ 🧪 mac-wk2	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc-arm64	❌ 🛠 tv	❌ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-armv7
	❌ 🛠 tv-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch		❌ 🛠 jsc-mips
	❌ 🛠 watch-sim		❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-13T18:11:50Z

EWS run on previous version of this PR (hash 855715e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	❌ 🛠 gtk
	~~🧪 ios-wk2-wpt~~	~~🧪 mac-wk1~~	❌ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	❌ 🧪 api-gtk
~~🛠 🧪 jsc-arm64~~	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-armv7
	✅ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	❌ 🛠 watch		❌ 🛠 jsc-mips
	⏳ 🛠 watch-sim		❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-13T18:45:59Z

EWS run on previous version of this PR (hash 774d62d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	⏳ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	⏳ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	~~🧪 ios-wk2~~	~~🧪 api-mac~~	✅ 🛠 gtk
	⏳ 🧪 ios-wk2-wpt	~~🧪 mac-wk1~~	~~🧪 gtk-wk2~~
⏳ 🛠 🧪 jsc	~~🧪 api-ios~~	~~🧪 mac-wk2~~	~~🧪 api-gtk~~
⏳ 🛠 🧪 jsc-arm64	⏳ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-armv7
	⏳ 🛠 tv-sim		❌ 🧪 jsc-armv7-tests
	⏳ 🛠 watch		❌ 🛠 jsc-mips
	⏳ 🛠 watch-sim		❌ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-10-13T18:56:38Z

EWS run on previous version of this PR (hash 02ed7bb)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	❌ 🧪 wpe-wk2	⏳ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	⏳ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	⏳ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim		✅ 🧪 api-gtk
	✅ 🛠 watch		❌ 🛠 jsc-armv7
	✅ 🛠 watch-sim		❌ 🧪 jsc-armv7-tests

achristensen07 · 2023-10-14T02:59:45Z

According to https://docs.webkit.org/Ports/WebKitGTK%20and%20WPE%20WebKit/DependenciesPolicy.html we are planning to support Debian 11 with gcc 10 until 2024-06-10. I don't think we can do this until then.

djg

https://bugs.webkit.org/show_bug.cgi?id=274952 rdar://129048503 Reviewed by Abrar Rahman Protyasha. This is the parts of WebKit#19053 that don't involve actually changing the compiler flag, which we can't do until June 10 because of the GTK and WPE dependencies policy. From that PR: 1. std::aligned_storage is deprecated, so I added deprecation warning ignoring macros around its use in order to not change any behavior with the transition. We can figure out what to do later. 2. Something about implicitly calling constructors changed, which affected code in JSBigInt. I fixed this by just adding braces to more explicitly indicate that a different type is being returned and we are calling a constructor. This should also not change behavior. 3. For a reason I don't completely understand, in order to fix the build I needed to change the name of WasmMemory::check to checkLifetime. "check" is certainly not a new keyword. This also does not change any behavior. 4. std::unique_ptr is now constexpr, and something in libc++'s implementation requires a complete class definition for its move constructor. I filed rdar://116885103 for future investigation, but I also moved a few definitions around and included a few things to fix the build. The SerializedScriptValue constructor taking a unique_ptr<WasmModuleArray> was a little tricky, but I made it just take a WasmModuleArray&& instead, and call makeUnique between that and initializing the member variable, so I didn't change behavior or storage layout there either. 5. I needed to explicitly include <iterator> from EmbeddedFixedVector.h to fix the build. Something probably changed about what standardized headers include other standardized headers. * Source/JavaScriptCore/assembler/ProbeStack.h: * Source/JavaScriptCore/dfg/DFGAbstractValue.cpp: (JSC::DFG::AbstractValue::ensureCanInitializeWithZeros): * Source/JavaScriptCore/runtime/JSBigInt.cpp: (JSC::JSBigInt::exponentiateImpl): (JSC::JSBigInt::multiplyImpl): (JSC::JSBigInt::remainderImpl): (JSC::JSBigInt::leftShiftImpl): (JSC::JSBigInt::signedRightShiftImpl): (JSC::JSBigInt::absoluteAdd): (JSC::JSBigInt::absoluteSub): (JSC::JSBigInt::asIntNImpl): (JSC::JSBigInt::asUintNImpl): * Source/JavaScriptCore/wasm/WasmMemory.h: * Source/JavaScriptCore/wasm/js/JSWebAssemblyMemory.cpp: (JSC::JSWebAssemblyMemory::adopt): (JSC::JSWebAssemblyMemory::growSuccessCallback): * Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/include/audio_processing.cc: * Source/ThirdParty/libwebrtc/Source/webrtc/modules/audio_processing/include/audio_processing.h: * Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/untyped_function.h: * Source/WTF/wtf/EmbeddedFixedVector.h: * Source/WTF/wtf/HashTable.h: (WTF::KeyTraits>::checkKey): * Source/WTF/wtf/Int128.cpp: * Source/WTF/wtf/Int128.h: * Source/WTF/wtf/NeverDestroyed.h: * Source/WTF/wtf/RobinHoodHashTable.h: (WTF::SizePolicy>::checkKey): * Source/WTF/wtf/SizeLimits.cpp: * Source/WTF/wtf/ThreadSpecific.h: * Source/WTF/wtf/Vector.h: * Source/WTF/wtf/threads/Signals.h: * Source/WebCore/bindings/js/SerializedScriptValue.cpp: (WebCore::SerializedScriptValue::SerializedScriptValue): (WebCore::SerializedScriptValue::create): * Source/WebCore/bindings/js/SerializedScriptValue.h: * Source/WebCore/dom/TreeScope.cpp: * Source/WebCore/html/HTMLMediaElement.cpp: * Source/WebCore/page/CaptionUserPreferences.cpp: (WebCore::CaptionUserPreferences::createTestingModeToken): * Source/WebCore/page/CaptionUserPreferences.h: (WebCore::CaptionUserPreferences::createTestingModeToken): Deleted. * Source/WebCore/rendering/GridTrackSizingAlgorithm.cpp: (WebCore::GridTrackSizingAlgorithm::GridTrackSizingAlgorithm): * Source/WebCore/rendering/GridTrackSizingAlgorithm.h: * Source/WebGPU/WGSL/Types.h: * Source/WebKit/Shared/Cocoa/APIObject.mm: * Source/WebKit/Shared/Cocoa/WKObject.h: * Source/WebKit/Shared/RemoteLayerTree/LayerProperties.h: (WebKit::RemoteLayerBackingStoreOrProperties::RemoteLayerBackingStoreOrProperties): Deleted. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStoreOrProperties::RemoteLayerBackingStoreOrProperties): * Source/WebKit/UIProcess/WebBackForwardCache.cpp: (WebKit::WebBackForwardCache::addEntry): * Source/WebKit/UIProcess/WebBackForwardCacheEntry.h: * Source/bmalloc/bmalloc/AllIsoHeaps.h: * Source/bmalloc/bmalloc/BCompiler.h: * Source/bmalloc/bmalloc/CryptoRandom.cpp: * Source/bmalloc/bmalloc/DebugHeap.h: * Source/bmalloc/bmalloc/Environment.h: * Source/bmalloc/bmalloc/Gigacage.cpp: * Source/bmalloc/bmalloc/HeapConstants.h: * Source/bmalloc/bmalloc/IsoSharedHeap.h: * Source/bmalloc/bmalloc/IsoTLSLayout.h: * Source/bmalloc/bmalloc/PerHeapKind.h: * Source/bmalloc/bmalloc/Scavenger.h: Canonical link: https://commits.webkit.org/279578@main

webkit-early-warning-system · 2024-06-14T17:38:22Z

EWS run on previous version of this PR (hash 44d4a74)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	❌ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch		❌ 🛠 jsc-armv7
	✅ 🛠 watch-sim		❌ 🧪 jsc-armv7-tests

Constellation

r=me

aprotyas

🚢 🚢 🚢

webkit-early-warning-system · 2024-06-15T14:36:51Z

EWS run on previous version of this PR (hash d3dfa2f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	✅ 🛠 watch		~~🛠 jsc-armv7~~
	✅ 🛠 watch-sim		~~🧪 jsc-armv7-tests~~

webkit-early-warning-system · 2024-06-15T16:13:29Z

EWS run on previous version of this PR (hash c9def1f)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	❌ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	❌ 🧪 wincairo-tests
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2-stress	❌ 🧪 api-gtk
	✅ 🛠 watch		~~🛠 jsc-armv7~~
	✅ 🛠 watch-sim		~~🧪 jsc-armv7-tests~~

webkit-early-warning-system · 2024-06-20T01:31:05Z

EWS run on current version of this PR (hash e30ecb3)

Misc	iOS, visionOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2	✅ 🧪 wincairo-tests
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 api-wpe
	❌ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🛠 wpe-cairo
✅ 🛠 🧪 jsc	~~🧪 api-ios~~	✅ 🧪 mac-wk2	✅ 🛠 gtk
✅ 🛠 🧪 jsc-arm64	⏳ 🛠 vision	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 gtk-wk2
	⏳ 🛠 vision-sim	✅ 🧪 mac-wk2-stress	✅ 🧪 api-gtk
	⏳ 🧪 vision-wk2		~~🛠 jsc-armv7~~
✅ 🛠 🧪 unsafe-merge	✅ 🛠 tv		~~🧪 jsc-armv7-tests~~
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

achristensen07 · 2024-06-20T20:44:53Z

iOS EWS is having some unrelated issues.

https://bugs.webkit.org/show_bug.cgi?id=263122 rdar://116922827 Reviewed by Yusuke Suzuki, Abrar Rahman Protyasha and Dan Glastonbury. * CMakeLists.txt: * Configurations/CommonBase.xcconfig: * Source/JavaScriptCore/Configurations/Base.xcconfig: * Source/JavaScriptCore/DerivedSources.make: * Source/ThirdParty/ANGLE/Configurations/Base.xcconfig: * Source/ThirdParty/gmock/Configurations/Base.xcconfig: * Source/ThirdParty/gtest/xcode/Config/General.xcconfig: * Source/ThirdParty/libwebrtc/CMakeLists.txt: * Source/ThirdParty/libwebrtc/Configurations/Base.xcconfig: * Source/WTF/Configurations/Base.xcconfig: * Source/WebCore/Configurations/Base.xcconfig: * Source/WebCore/DerivedSources.make: * Source/WebCore/PAL/Configurations/Base.xcconfig: * Source/WebCore/PAL/ThirdParty/libavif/Configurations/Base.xcconfig: * Source/WebCore/PAL/ThirdParty/libavif/ThirdParty/dav1d/Configurations/Base.xcconfig: * Source/WebGPU/Configurations/Base.xcconfig: * Source/WebInspectorUI/Configurations/Base.xcconfig: * Source/WebKit/Configurations/Base.xcconfig: * Source/WebKit/DerivedSources.make: * Source/WebKit/PlatformMac.cmake: * Source/WebKitLegacy/PlatformMac.cmake: * Source/WebKitLegacy/mac/Configurations/Base.xcconfig: * Source/bmalloc/Configurations/Base.xcconfig: * Source/bmalloc/libpas/CMakeLists.txt: * Source/cmake/OptionsCommon.cmake: * Source/cmake/WebKitCompilerFlags.cmake: * Tools/DumpRenderTree/DerivedSources.make: * Tools/DumpRenderTree/mac/Configurations/Base.xcconfig: * Tools/MiniBrowser/Configurations/Base.xcconfig: * Tools/MobileMiniBrowser/Configurations/Base.xcconfig: * Tools/Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl: * Tools/TestWebKitAPI/Configurations/Base.xcconfig: * Tools/WebGPUPlayground/Configurations/Base.xcconfig: * Tools/WebKitTestRunner/Configurations/Base.xcconfig: * Tools/WebKitTestRunner/DerivedSources.make: * Tools/lldb/lldbWebKitTester/Configurations/Base.xcconfig: Canonical link: https://commits.webkit.org/280217@main

webkit-commit-queue · 2024-06-20T20:47:05Z

Committed 280217@main (619fc6b): https://commits.webkit.org/280217@main

Reviewed commits have been landed. Closing PR #19053 and removing active labels.

achristensen07 requested review from litherum, djg, tadeuzagallo, mwyrzykowski, mcatanzaro, cdumez, rniwa, dcrousso, patrickangle and a team as code owners October 13, 2023 16:26

achristensen07 self-assigned this Oct 13, 2023

achristensen07 requested review from Constellation and JonWBedard as code owners October 13, 2023 16:26

achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Oct 13, 2023

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 13, 2023

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Oct 13, 2023

achristensen07 force-pushed the eng/Begin-using-C23-in-WebKit branch from b062a4b to 855715e Compare October 13, 2023 18:11

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 13, 2023

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Oct 13, 2023

achristensen07 force-pushed the eng/Begin-using-C23-in-WebKit branch from 855715e to 774d62d Compare October 13, 2023 18:45

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 13, 2023

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Oct 13, 2023

achristensen07 force-pushed the eng/Begin-using-C23-in-WebKit branch from 774d62d to 02ed7bb Compare October 13, 2023 18:56

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 13, 2023

djg approved these changes Oct 16, 2023

View reviewed changes

achristensen07 mentioned this pull request May 31, 2024

Prepare to use C++23 in WebKit #29360

Merged

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Jun 14, 2024

achristensen07 force-pushed the eng/Begin-using-C23-in-WebKit branch from 02ed7bb to 44d4a74 Compare June 14, 2024 17:38

achristensen07 requested a review from emw-apple as a code owner June 14, 2024 17:38

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 14, 2024

Constellation approved these changes Jun 14, 2024

View reviewed changes

aprotyas approved these changes Jun 14, 2024

View reviewed changes

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Jun 15, 2024

achristensen07 force-pushed the eng/Begin-using-C23-in-WebKit branch from 44d4a74 to d3dfa2f Compare June 15, 2024 14:36

achristensen07 force-pushed the eng/Begin-using-C23-in-WebKit branch from d3dfa2f to c9def1f Compare June 15, 2024 16:13

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 15, 2024

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Jun 20, 2024

achristensen07 force-pushed the eng/Begin-using-C23-in-WebKit branch from c9def1f to e30ecb3 Compare June 20, 2024 01:31

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 20, 2024

achristensen07 removed the merging-blocked Applied to prevent a change from being merged label Jun 20, 2024

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jun 20, 2024

achristensen07 added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jun 20, 2024

webkit-commit-queue force-pushed the eng/Begin-using-C23-in-WebKit branch from e30ecb3 to 619fc6b Compare June 20, 2024 20:47

webkit-commit-queue merged commit 619fc6b into WebKit:main Jun 20, 2024

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jun 20, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Begin using C++23 in WebKit #19053

Begin using C++23 in WebKit #19053

achristensen07 commented Oct 13, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Oct 13, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2023 •

edited

Loading

achristensen07 commented Oct 14, 2023

djg left a comment

webkit-early-warning-system commented Jun 14, 2024 •

edited

Loading

Constellation left a comment

aprotyas left a comment

webkit-early-warning-system commented Jun 15, 2024 •

edited

Loading

webkit-early-warning-system commented Jun 15, 2024 •

edited

Loading

webkit-early-warning-system commented Jun 20, 2024 •

edited

Loading

achristensen07 commented Jun 20, 2024

webkit-commit-queue commented Jun 20, 2024

Begin using C++23 in WebKit #19053

Begin using C++23 in WebKit #19053

Conversation

achristensen07 commented Oct 13, 2023 • edited by webkit-early-warning-system Loading

619fc6b

webkit-early-warning-system commented Oct 13, 2023 • edited Loading

webkit-early-warning-system commented Oct 13, 2023 • edited Loading

webkit-early-warning-system commented Oct 13, 2023 • edited Loading

webkit-early-warning-system commented Oct 13, 2023 • edited Loading

achristensen07 commented Oct 14, 2023

djg left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Jun 14, 2024 • edited Loading

Constellation left a comment

Choose a reason for hiding this comment

aprotyas left a comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Jun 15, 2024 • edited Loading

webkit-early-warning-system commented Jun 15, 2024 • edited Loading

webkit-early-warning-system commented Jun 20, 2024 • edited Loading

achristensen07 commented Jun 20, 2024

webkit-commit-queue commented Jun 20, 2024

achristensen07 commented Oct 13, 2023 •

edited by webkit-early-warning-system

Loading

`619fc6b`

webkit-early-warning-system commented Oct 13, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 13, 2023 •

edited

Loading

webkit-early-warning-system commented Jun 14, 2024 •

edited

Loading

webkit-early-warning-system commented Jun 15, 2024 •

edited

Loading

webkit-early-warning-system commented Jun 15, 2024 •

edited

Loading

webkit-early-warning-system commented Jun 20, 2024 •

edited

Loading