Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-interactive flag for build-and-collect-pgo-profiles #1910

Conversation

briannafan
Copy link
Contributor

@briannafan briannafan commented Jun 29, 2022

211c1d8

Add non-interactive flag for build-and-collect-pgo-profiles
https://bugs.webkit.org/show_bug.cgi?id=242127

Reviewed by Dewei Zhu.

Allow script to run without user input for automatic collection process.

* Tools/Scripts/build-and-collect-pgo-profiles:

Canonical link: https://commits.webkit.org/251959@main

Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@dewei-zhu
Copy link
Contributor

Let's add some more detailed description under above line * Tools/Scripts/build-and-collect-pgo-profiles:

@briannafan briannafan force-pushed the eng/Add-non-interactive-flag-for-build-and-collect-pgo-profiles branch from 2ba55fb to 31b48ed Compare June 29, 2022 18:50
@dewei-zhu dewei-zhu added the merge-queue Applied to send a pull request to merge-queue label Jun 29, 2022
https://bugs.webkit.org/show_bug.cgi?id=242127

Reviewed by Dewei Zhu.

Allow script to run without user input for automatic collection process.

* Tools/Scripts/build-and-collect-pgo-profiles:

Canonical link: https://commits.webkit.org/251959@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Add-non-interactive-flag-for-build-and-collect-pgo-profiles branch from 31b48ed to 211c1d8 Compare June 29, 2022 19:54
@webkit-commit-queue
Copy link
Collaborator

Committed 251959@main (211c1d8): https://commits.webkit.org/251959@main

Reviewed commits have been landed. Closing PR #1910 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 211c1d8 into WebKit:main Jun 29, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jun 29, 2022
@briannafan briannafan deleted the eng/Add-non-interactive-flag-for-build-and-collect-pgo-profiles branch June 29, 2022 20:49
@briannafan briannafan restored the eng/Add-non-interactive-flag-for-build-and-collect-pgo-profiles branch June 30, 2022 16:56
yury-s pushed a commit to yury-s/WebKit that referenced this pull request Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants