Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resync 'svg/types/scripted/' from WPT upstream #19188

Merged
merged 1 commit into from Oct 18, 2023

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Oct 17, 2023

8a42f71

Resync 'svg/types/scripted/' from WPT upstream

https://bugs.webkit.org/show_bug.cgi?id=263281

Reviewed by Tim Nguyen.

This PR is to upstream all tests from 'svg/types/scripted/' directory based on WPT ToT hash:

Upstream hash: bbb13dc253827791419344169e822c1af8c2cd82

* LayoutTests/imported/w3c/web-platform-tests/__init__.py:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/event-handler-all-document-element-events.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/event-handler-all-document-element-events-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedEnumeration-SVGFECompositeElement.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted//SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedEnumeration-SVGMarkerElement.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted//SVGAnimatedEnumeration-SVGMarkerElement-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedRect.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedRect-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGElement.className-01.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGElement.className-01-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-02.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-02.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.isPointInFill-01.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.isPointInFill-01-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.isPointInStroke-01.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement-clone-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement-clone.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement.getBBox-03-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement.getBBox-03.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-cap-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-cap.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ic.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-lh-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-lh.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px-with-context-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px-with-context.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rem-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rem.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/svglength-value-access-when-in-detached-document-crash.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-viewport-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-viewport.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGPoint-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGPoint.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/w3c-import.log

Canonical link: https://commits.webkit.org/269468@main

cb7f8c0

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
  πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
  πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@Ahmad-S792 Ahmad-S792 added the SVG For bugs in the SVG implementation. label Oct 17, 2023
@Ahmad-S792 Ahmad-S792 self-assigned this Oct 17, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 17, 2023
@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review October 18, 2023 06:39
@Ahmad-S792 Ahmad-S792 removed the merging-blocked Applied to prevent a change from being merged label Oct 18, 2023
@Ahmad-S792
Copy link
Contributor Author

Note - I am importing these tests to update them since they are quite old and also fix a bug, which was false positives with old tests but now with new imported test suites, it passes.

@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Oct 18, 2023
https://bugs.webkit.org/show_bug.cgi?id=263281

Reviewed by Tim Nguyen.

This PR is to upstream all tests from 'svg/types/scripted/' directory based on WPT ToT hash:

Upstream hash: bbb13dc253827791419344169e822c1af8c2cd82

* LayoutTests/imported/w3c/web-platform-tests/__init__.py:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/event-handler-all-document-element-events.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/event-handler-all-document-element-events-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedEnumeration-SVGFECompositeElement.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted//SVGAnimatedEnumeration-SVGFECompositeElement-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedEnumeration-SVGMarkerElement.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted//SVGAnimatedEnumeration-SVGMarkerElement-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedRect.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGAnimatedRect-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGElement.className-01.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGElement.className-01-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-02.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-02.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-03.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-04-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.getPointAtLength-05-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.isPointInFill-01.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.isPointInFill-01-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGeometryElement.isPointInStroke-01.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement-clone-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement-clone.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement.getBBox-03-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement.getBBox-03.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGGraphicsElement.svg:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-cap-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-cap.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ch.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-ic.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-lh-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-lh.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px-with-context-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px-with-context.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-px.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rem-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-rem.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/svglength-value-access-when-in-detached-document-crash.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-viewport-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGLength-viewport.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGPoint-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/SVGPoint.html:
* LayoutTests/imported/w3c/web-platform-tests/svg/types/scripted/w3c-import.log

Canonical link: https://commits.webkit.org/269468@main
@webkit-commit-queue
Copy link
Collaborator

Committed 269468@main (8a42f71): https://commits.webkit.org/269468@main

Reviewed commits have been landed. Closing PR #19188 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 8a42f71 into WebKit:main Oct 18, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 18, 2023
@Ahmad-S792 Ahmad-S792 deleted the fix263281 branch December 30, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SVG For bugs in the SVG implementation.
Projects
None yet
5 participants