Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt inactiveSchedulingPolicy for Web Extension background pages. #19193

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Adopt inactiveSchedulingPolicy for Web Extension background pages. #19193

merged 1 commit into from
Oct 18, 2023

Conversation

xeenon
Copy link
Contributor

@xeenon xeenon commented Oct 17, 2023 •
edited by webkit-early-warning-system
Loading

c57208d

Adopt inactiveSchedulingPolicy for Web Extension background pages.
https://bugs.webkit.org/show_bug.cgi?id=263287
rdar://problem/117096484

Reviewed by Brian Weinstein, Brent Fulgham and Chris Dumez.

Adopt `_hiddenPageDOMTimerThrottlingEnabled` on all platform, instead of the macOS only `_domTimersThrottlingEnabled`.
Also adopt `inactiveSchedulingPolicy` by setting it to `WKInactiveSchedulingPolicyNone` to prevent runningboard from
suspending the background page and inspector background page.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::webViewConfiguration):
* Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController webViewConfiguration]):

Canonical link: https://commits.webkit.org/269445@main

41a9361

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
  🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@xeenon xeenon self-assigned this Oct 17, 2023
@xeenon xeenon changed the title https://bugs.webkit.org/show_bug.cgi?id=263287 Adopt inactiveSchedulingPolicy for Web Extension background pages. Oct 17, 2023
@xeenon xeenon added the WebKit Extensions Bugs related to extension support. label Oct 17, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 17, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 3720c00)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios   🛠 mac   🛠 wpe   🛠 wincairo
  🛠 ios-sim   🛠 mac-AS-debug   🧪 wpe-wk2
  🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
  🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim   🧪 mac-wk2-stress
  🛠 watch
  🛠 watch-sim

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 17, 2023 •
edited
Loading

EWS run on current version of this PR (hash 41a9361)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style   🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2 ❌ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 gtk-wk2
⏳ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
  🛠 tv   🧪 mac-AS-debug-wk2
  🛠 tv-sim
  🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@xeenon xeenon added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Oct 17, 2023
@xeenon xeenon added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Oct 18, 2023
@xeenon
Adopt inactiveSchedulingPolicy for Web Extension background pages.
c57208d 
https://bugs.webkit.org/show_bug.cgi?id=263287
rdar://problem/117096484

Reviewed by Brian Weinstein, Brent Fulgham and Chris Dumez.

Adopt `_hiddenPageDOMTimerThrottlingEnabled` on all platform, instead of the macOS only `_domTimersThrottlingEnabled`.
Also adopt `inactiveSchedulingPolicy` by setting it to `WKInactiveSchedulingPolicyNone` to prevent runningboard from
suspending the background page and inspector background page.

* Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm:
(WebKit::WebExtensionContext::webViewConfiguration):
* Source/WebKit/UIProcess/Inspector/mac/WKInspectorViewController.mm:
(-[WKInspectorViewController webViewConfiguration]):

Canonical link: https://commits.webkit.org/269445@main
@webkit-commit-queue
Copy link
Collaborator

Committed 269445@main (c57208d): https://commits.webkit.org/269445@main

Reviewed commits have been landed. Closing PR #19193 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit c57208d into WebKit:main Oct 18, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 18, 2023
@xeenon xeenon deleted the bug/263287 branch October 18, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

@brentfulgham brentfulgham brentfulgham approved these changes

@b-weinstein b-weinstein b-weinstein approved these changes

@kiaraarose kiaraarose Awaiting requested review from kiaraarose

Assignees

@xeenon xeenon

Labels
WebKit Extensions Bugs related to extension support.
Projects
None yet
Milestone
No milestone
6 participants
@xeenon @webkit-early-warning-system @webkit-commit-queue @cdumez @brentfulgham @b-weinstein