Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::span in canUseSimplifiedTextMeasuringForCharacters() #19238

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Use std::span in canUseSimplifiedTextMeasuringForCharacters() #19238

merged 1 commit into from
Oct 18, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Oct 18, 2023 •
edited by webkit-early-warning-system
Loading

1d59b86

Use std::span in canUseSimplifiedTextMeasuringForCharacters()
https://bugs.webkit.org/show_bug.cgi?id=263328

Reviewed by Darin Adler.

Follow-up to 269396@main to address Darin's review comments.

* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::canUseSimplifiedTextMeasuringForCharacters):
(WebCore::Layout::TextUtil::canUseSimplifiedTextMeasuring):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::canUseSimplifiedTextMeasuringForCharacters):
(WebCore::Layout::canUseSimplifiedTextMeasuring):

Canonical link: https://commits.webkit.org/269491@main

0c1f33d

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 🧪 merge   🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez self-assigned this Oct 18, 2023
@cdumez cdumez added the Layout and Rendering For bugs with layout and rendering of Web pages. label Oct 18, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 18, 2023 •
edited
Loading

EWS run on previous version of this PR (hash ad55e98)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios   🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ⏳ 🛠 ios-sim   🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac   🛠 gtk
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 tv   🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim   🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

@cdumez cdumez mentioned this pull request Oct 18, 2023
Merged
@cdumez cdumez force-pushed the 263328_canUseSimplifiedTextMeasuringForCharacters_span branch from ad55e98 to 02ad228 Compare October 18, 2023 18:52
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 18, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 02ad228)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios   🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ⏳ 🛠 ios-sim ❌ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ⏳ 🛠 gtk
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2 ⏳ 🧪 api-gtk
⏳ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim   🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

@cdumez cdumez force-pushed the 263328_canUseSimplifiedTextMeasuringForCharacters_span branch from 02ad228 to 3a3f081 Compare October 18, 2023 18:55
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 18, 2023 •
edited
Loading

EWS run on previous version of this PR (hash 3a3f081)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ⏳ 🛠 ios   🛠 mac   🛠 wpe ⏳ 🛠 wincairo
✅ 🧪 bindings ⏳ 🛠 ios-sim ❌ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac ⏳ 🛠 gtk
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1 ⏳ 🧪 gtk-wk2
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2 ⏳ 🧪 api-gtk
❌ 🛠 tv ❌ 🧪 mac-AS-debug-wk2
⏳ 🛠 tv-sim   🧪 mac-wk2-stress
⏳ 🛠 watch
⏳ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Oct 18, 2023
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Oct 18, 2023
@cdumez cdumez force-pushed the 263328_canUseSimplifiedTextMeasuringForCharacters_span branch from 3a3f081 to 0c1f33d Compare October 18, 2023 19:02
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 18, 2023 •
edited
Loading

EWS run on current version of this PR (hash 0c1f33d)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 🧪 merge   🛠 watch
✅ 🛠 watch-sim

@cdumez cdumez marked this pull request as ready for review October 18, 2023 19:48
@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Oct 18, 2023
@cdumez
Use std::span in canUseSimplifiedTextMeasuringForCharacters()
1d59b86 
https://bugs.webkit.org/show_bug.cgi?id=263328

Reviewed by Darin Adler.

Follow-up to 269396@main to address Darin's review comments.

* Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:
(WebCore::Layout::canUseSimplifiedTextMeasuringForCharacters):
(WebCore::Layout::TextUtil::canUseSimplifiedTextMeasuring):
* Source/WebCore/layout/layouttree/LayoutTreeBuilder.cpp:
(WebCore::Layout::canUseSimplifiedTextMeasuringForCharacters):
(WebCore::Layout::canUseSimplifiedTextMeasuring):

Canonical link: https://commits.webkit.org/269491@main
@webkit-commit-queue webkit-commit-queue force-pushed the 263328_canUseSimplifiedTextMeasuringForCharacters_span branch from 0c1f33d to 1d59b86 Compare October 18, 2023 23:53
@webkit-commit-queue
Copy link
Collaborator

Committed 269491@main (1d59b86): https://commits.webkit.org/269491@main

Reviewed commits have been landed. Closing PR #19238 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 1d59b86 into WebKit:main Oct 18, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darinadler darinadler darinadler approved these changes

Assignees

@cdumez cdumez

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @webkit-commit-queue @darinadler @webkit-ews-buildbot