Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JSC] Fix Air OptimizePairedLoadStore missing header includes #19242

Merged
merged 1 commit into from
Dec 30, 2023
Merged

[JSC] Fix Air OptimizePairedLoadStore missing header includes #19242

merged 1 commit into from
Dec 30, 2023

Conversation

leio
Copy link
Contributor

@leio leio commented Oct 18, 2023 •
edited by webkit-early-warning-system
Loading

b9d0bc2

[JSC] Fix Air OptimizePairedLoadStore missing header includes
https://bugs.webkit.org/show_bug.cgi?id=266936

Reviewed by Justin Michaud.

Fixes compile errors with non-unified build by adding missing include files for
single unit compilation.
Fixed compilation errors:

error: incomplete type 'JSC::CCallHelpers' named in nested name specifier
error: function 'JSC::B3::Air::Inst::forEachDefWithExtraClobberedRegs<JSC::B3::Air::Tmp, (lambda at ...)>' is used but not defined in this translation unit, and cannot be defined in any other translation unit because its type does not have linkage

* Source/JavaScriptCore/b3/air/AirOptimizePairedLoadStore.cpp

Canonical link: https://commits.webkit.org/272532@main

970db66

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@leio leio requested a review from a team as a code owner October 18, 2023 19:58
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 18, 2023 •
edited
Loading

EWS run on previous version of this PR (hash c5e6641)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ⏳ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc 💥 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

justinmichaud
justinmichaud approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@justinmichaud justinmichaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@leio
Copy link
Contributor Author

leio commented Dec 29, 2023

I'm not familiar with the process, sorry - how do I get this to proceed after a couple months now? :)

@Ahmad-S792
Copy link
Contributor

I'm not familiar with the process, sorry - how do I get this to proceed after a couple months now? :)

Can you raise bug on bugs.webkit.org with similar title and add it in commit message before Reviewed by NOBODY.. and then can you rebase this patch (squash all commits) on top tree so it is easier to merge. Once done, I will add merge-queue and it will be merged.

@Ahmad-S792 Ahmad-S792 added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Dec 29, 2023
@leio leio force-pushed the AirOptimizePairedLoadStore-includes branch from c5e6641 to 970db66 Compare December 29, 2023 22:46
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Dec 29, 2023 •
edited
Loading

EWS run on current version of this PR (hash 970db66)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 api-wpe
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🛠 gtk
✅ 🛠 🧪 jsc ✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 gtk-wk2
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv-sim ✅ 🛠 jsc-armv7
✅ 🛠 🧪 merge ✅ 🛠 watch ✅ 🧪 jsc-armv7-tests
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Dec 29, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Dec 30, 2023
@webkit-ews-buildbot
Copy link
Collaborator

Safe-Merge-Queue: Build #7686.

@leio
[JSC] Fix Air OptimizePairedLoadStore missing header includes
b9d0bc2 
https://bugs.webkit.org/show_bug.cgi?id=266936

Reviewed by Justin Michaud.

Fixes compile errors with non-unified build by adding missing include files for
single unit compilation.
Fixed compilation errors:

error: incomplete type 'JSC::CCallHelpers' named in nested name specifier
error: function 'JSC::B3::Air::Inst::forEachDefWithExtraClobberedRegs<JSC::B3::Air::Tmp, (lambda at ...)>' is used but not defined in this translation unit, and cannot be defined in any other translation unit because its type does not have linkage

* Source/JavaScriptCore/b3/air/AirOptimizePairedLoadStore.cpp

Canonical link: https://commits.webkit.org/272532@main
@webkit-commit-queue
Copy link
Collaborator

Committed 272532@main (b9d0bc2): https://commits.webkit.org/272532@main

Reviewed commits have been landed. Closing PR #19242 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Dec 30, 2023
@webkit-commit-queue webkit-commit-queue merged commit b9d0bc2 into WebKit:main Dec 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmichaud justinmichaud justinmichaud approved these changes

Assignees

@leio leio

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
6 participants
@leio @webkit-early-warning-system @Ahmad-S792 @webkit-ews-buildbot @webkit-commit-queue @justinmichaud