Add support for more InputEvent initialization paramaters, such as dataTransfer and targetRanges

[MoeBazziGIT]

53824ba

This adds support for more initialization paramaters for InputEvent, such as dataTransfer and targetRanges
https://bugs.webkit.org/show_bug.cgi?id=170416

Reviewed by NOBODY (OOPS!).

* Source/WebCore/dom/InputEvent.cpp:
(WebCore::InputEvent::InputEvent):
* Source/WebCore/dom/InputEvent.h:
* Source/WebCore/dom/InputEvent.idl:

53824ba

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[webkit-early-warning-system]

EWS run on current version of this PR (hash 53824ba)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

[whsieh]

Thanks for the patch! A couple of comments:

1. Move the summary describing the change in the commit message, below the bug number and change the title to be consistent with the bugzilla bug. i.e.,:

Support InputEventInit.{inputType, dataTransfer, isComposing, targetRanges}
https://bugs.webkit.org/show_bug.cgi?id=170416

Reviewed by NOBODY (OOPS!).

This adds support for more initialization parameters for InputEvent, such as dataTransfer and targetRanges.

* Source/WebCore/dom/InputEvent.cpp:
(WebCore::InputEvent::InputEvent):
* Source/WebCore/dom/InputEvent.h:
* Source/WebCore/dom/InputEvent.idl:

2. We should add a new test (or modify existing tests) to reflect this change. The existing WPT imported/w3c/web-platform-tests/uievents/constructors/inputevent-constructor.html seems pertinent.

It seems like the spec doesn't include these two arguments, but testing in Chrome and Firefox, I can see that they both allow you to specify targetRanges and dataTransfer in InputEventInit, so this change would align with Firefox/Chrome. It seems that the spec just needs to be updated.

[whsieh]

Nit - can we keep these in an order that's consistent with the IDL? (i.e. dataTransfer and then targetRanges)

[johanneswilm]

It seems like the spec doesn't include these two arguments

@whsieh I've added it to the next Web Editing Workforce call. However, I am thinking maybe there is only some confusion because half the IDL is in the uievents spec and the other half in the input events spec. The relevant part is in the input events spec: https://w3c.github.io/input-events/#interface-InputEvent