Don't adopt result of NSURLSession.sessionWithConfiguration #19393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achristensen07
added
the
WebKit Misc.
|
EWS run on current version of this PR (hash cb70fad)
|
achristensen07
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=263501 Reviewed by Chris Dumez. If it were ever released, it would cause memory corruption. It's not, but still not good practice. * Source/WebKit/NetworkProcess/PrivateClickMeasurement/cocoa/PrivateClickMeasurementNetworkLoaderCocoa.mm: (WebKit::PCM::statelessSessionWithoutRedirects): Canonical link: https://commits.webkit.org/269631@main
webkit-commit-queue
force-pushed
the
eng/Dont-adopt-result-of-NSURLSession-sessionWithConfiguration
branch
from
cb70fad
to
bfc8bf8
Compare
|
Committed 269631@main (bfc8bf8): https://commits.webkit.org/269631@main Reviewed commits have been landed. Closing PR #19393 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bfc8bf8
cb70fad
🛠 wincairo🧪 wpe-wk2🧪 ios-wk2🧪 ios-wk2-wpt🧪 gtk-wk2🧪 api-ios🧪 mac-wk2