Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Gardening] Add DumpJSConsoleLogInStdErr for Bug 185254 #19475

Merged
merged 1 commit into from
Oct 24, 2023
Merged

[Gardening] Add DumpJSConsoleLogInStdErr for Bug 185254 #19475

merged 1 commit into from
Oct 24, 2023

Conversation

fujii
Copy link
Contributor

@fujii fujii commented Oct 24, 2023 •
edited by webkit-early-warning-system

b02d123

[Gardening] Add DumpJSConsoleLogInStdErr for Bug 185254
https://bugs.webkit.org/show_bug.cgi?id=185254

Unreviewed test gardening. These tests are failing due to the
following extra console message on non-Cocoa ports.

> CONSOLE MESSAGE: line 22: Load cannot follow more than 20 redirections

Added DumpJSConsoleLogInStdErr for the tests.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/269709@main

0ca7024

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ⏳ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@fujii fujii self-assigned this Oct 24, 2023
@fujii fujii added the WebKitGTK Bugs related to the Gtk API layer. label Oct 24, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 0ca7024)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ⏳ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@fujii fujii added the safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks label Oct 24, 2023
@webkit-ews-buildbot webkit-ews-buildbot added merge-queue Applied to send a pull request to merge-queue and removed safe-merge-queue Applied to automatically send a pull-request to merge-queue after passing EWS checks labels Oct 24, 2023
@fujii
[Gardening] Add DumpJSConsoleLogInStdErr for Bug 185254
b02d123 
https://bugs.webkit.org/show_bug.cgi?id=185254

Unreviewed test gardening. These tests are failing due to the
following extra console message on non-Cocoa ports.

> CONSOLE MESSAGE: line 22: Load cannot follow more than 20 redirections

Added DumpJSConsoleLogInStdErr for the tests.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/gtk/TestExpectations:
* LayoutTests/platform/wincairo/TestExpectations:
* LayoutTests/platform/wpe/TestExpectations:

Canonical link: https://commits.webkit.org/269709@main
@webkit-commit-queue
Copy link
Collaborator

Test gardening commit 269709@main (b02d123): https://commits.webkit.org/269709@main

Reviewed commits have been landed. Closing PR #19475 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b02d123 into WebKit:main Oct 24, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 24, 2023
@fujii fujii deleted the eng/bug-185254-test-gardening branch October 25, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fujii fujii

Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
Milestone
No milestone
4 participants
@fujii @webkit-early-warning-system @webkit-commit-queue @webkit-ews-buildbot