Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[git-webkit] Handle comparing User and Contributor to None #195

Merged
merged 0 commits into from
Mar 14, 2022
Merged

[git-webkit] Handle comparing User and Contributor to None #195

merged 0 commits into from
Mar 14, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Mar 8, 2022 •
edited

8b72008

[git-webkit] Handle comparing User and Contributor to None
https://bugs.webkit.org/show_bug.cgi?id=237622
<rdar://problem/89992772 >

Reviewed by Dewei Zhu.

* Tools/Scripts/libraries/webkitbugspy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/tests/user_unittest.py:
(TestUser.test_compare):
* Tools/Scripts/libraries/webkitbugspy/webkitbugspy/user.py:
(User.__cmp__): Handle 'None' case.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/contributor.py:
(Contributor.__cmp__): Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/contributor_unittest.py:
(TestContributor.test_comparison):


Canonical link: https://commits.webkit.org/248397@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Mar 8, 2022
dewei-zhu
dewei-zhu approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@dewei-zhu dewei-zhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@JonWBedard JonWBedard force-pushed the eng/git-webkit-Handle-comparing-User-and-Contributor-to-None branch from 5247580 to a3640ba Compare March 14, 2022 18:43
@JonWBedard JonWBedard merged commit 8b72008 into WebKit:main Mar 14, 2022
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/248397@main (8b72008)!

@JonWBedard JonWBedard force-pushed the eng/git-webkit-Handle-comparing-User-and-Contributor-to-None branch from a3640ba to 8b72008 Compare March 14, 2022 18:49
@JonWBedard JonWBedard deleted the eng/git-webkit-Handle-comparing-User-and-Contributor-to-None branch March 14, 2022 18:49
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dewei-zhu dewei-zhu dewei-zhu approved these changes

@facetothefate facetothefate Awaiting requested review from facetothefate

@sundiamonde sundiamonde Awaiting requested review from sundiamonde

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
2 participants
@JonWBedard @dewei-zhu