Generate serialization for ScrollingStateFrameHostingNode #19580

achristensen07 · 2023-10-26T03:40:54Z

`887ac88`

Generate serialization for ScrollingStateFrameHostingNode
https://bugs.webkit.org/show_bug.cgi?id=263704
rdar://117513008

Reviewed by Brady Eidson.

This required some new constructors, but the interesting part was teaching the
code generator how to handle types with OptionalTupleBits and non-OptionalTuple members.

* Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.cpp:
(WebCore::ScrollingStateFrameHostingNode::create):
(WebCore::ScrollingStateFrameHostingNode::ScrollingStateFrameHostingNode):
* Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.h:
* Source/WebCore/page/scrolling/ScrollingStateNode.cpp:
(WebCore::ScrollingStateNode::ScrollingStateNode):
* Source/WebCore/page/scrolling/ScrollingStateNode.h:
* Source/WebKit/Scripts/generate-serializers.py:
(SerializedType.has_optional_tuple_bits):
(check_type_members):
(encode_type):
(decode_type):
(generate_one_impl):
(generate_serialized_type_info):
(encode_optional_tuple): Deleted.
(decode_optional_tuple): Deleted.
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp:
(IPC::ArgumentCoder<Namespace::Subnamespace::StructName>::encode):
(IPC::ArgumentCoder<Namespace::OtherClass>::encode):
(IPC::ArgumentCoder<Namespace::ReturnRefClass>::encode):
(IPC::ArgumentCoder<Namespace::EmptyConstructorStruct>::encode):
(IPC::ArgumentCoder<Namespace::EmptyConstructorWithIf>::encode):
(IPC::ArgumentCoder<WithoutNamespace>::encode):
(IPC::ArgumentCoder<WithoutNamespaceWithAttributes>::encode):
(IPC::ArgumentCoder<WebCore::InheritsFrom>::encode):
(IPC::ArgumentCoder<WebCore::InheritanceGrandchild>::encode):
(IPC::ArgumentCoder<WTF::Seconds>::encode):
(IPC::ArgumentCoder<WTF::CreateUsingClass>::encode):
(IPC::ArgumentCoder<WebCore::FloatBoxExtent>::encode):
(IPC::ArgumentCoder<SoftLinkedMember>::encode):
(IPC::ArgumentCoder<Namespace::ConditionalCommonClass>::encode):
(IPC::ArgumentCoder<Namespace::CommonClass>::encode):
(IPC::ArgumentCoder<Namespace::AnotherCommonClass>::encode):
(IPC::ArgumentCoder<WebCore::MoveOnlyDerivedClass>::encode):
(IPC::ArgumentCoder<WebKit::LayerProperties>::encode):
(IPC::ArgumentCoder<WebKit::LayerProperties>::decode):
(IPC::ArgumentCoder<WebKit::TemplateTest<WebKit::Fabulous>>::encode):
(IPC::ArgumentCoder<WebKit::TemplateTest<WebCore::Amazing>>::encode):
(IPC::ArgumentCoder<WebKit::TemplateTest<JSC::Incredible>>::encode):
(IPC::ArgumentCoder<WebKit::TemplateTest<Testing::StorageSize>>::encode):
(IPC::ArgumentCoder<WebCore::ScrollingStateFrameHostingNode>::encode):
(IPC::ArgumentCoder<WebCore::ScrollingStateFrameHostingNode>::decode):
(IPC::ArgumentCoder<WebCore::ScrollingStateFrameHostingNodeWithStuffAfterTuple>::encode):
(IPC::ArgumentCoder<WebCore::ScrollingStateFrameHostingNodeWithStuffAfterTuple>::decode):
* Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h:
* Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp:
(WebKit::allSerializedTypes):
* Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in:
* Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp:
(IPC::ArgumentCoder<WebKit::PlatformClass>::encode):
* Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in:
* Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:
(ArgumentCoder<WebCore::ScrollingStateFrameHostingNode>::encode): Deleted.
(ArgumentCoder<WebCore::ScrollingStateFrameHostingNode>::decode): Deleted.
* Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h:
* Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in:

Canonical link: https://commits.webkit.org/269811@main

c797d7e

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

webkit-early-warning-system · 2023-10-26T03:41:09Z

EWS run on previous version of this PR (hash 642ea5d)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	⏳ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	~~🧪 ios-wk2-wpt~~	✅ 🧪 mac-wk1	~~🧪 gtk-wk2~~
	⏳ 🧪 api-ios	~~🧪 mac-wk2~~	✅ 🧪 api-gtk
	✅ 🛠 tv	⏳ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
	✅ 🛠 watch-sim

beidson

LGTM.

I don't have the skillset to be hypercritical of the python changes, but they pass the sniff test and are regression tested, so... 👍

beidson · 2023-10-26T03:57:44Z

Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp

@@ -69,6 +69,7 @@ void ArgumentCoder<WebKit::PlatformClass>::encode(Encoder& encoder, const WebKit
    static_assert(MembersInCorrectOrder < 0
        , offsetof(WebKit::PlatformClass, value)
    >::value);
+


webkit-early-warning-system · 2023-10-26T05:07:28Z

EWS run on current version of this PR (hash c797d7e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 wincairo
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🧪 wpe-wk2
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🛠 gtk
✅ 🧪 webkitpy	✅ 🧪 ios-wk2-wpt	✅ 🧪 mac-wk1	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk2	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 tv-sim
	✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge	✅ 🛠 watch-sim

https://bugs.webkit.org/show_bug.cgi?id=263704 rdar://117513008 Reviewed by Brady Eidson. This required some new constructors, but the interesting part was teaching the code generator how to handle types with OptionalTupleBits and non-OptionalTuple members. * Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.cpp: (WebCore::ScrollingStateFrameHostingNode::create): (WebCore::ScrollingStateFrameHostingNode::ScrollingStateFrameHostingNode): * Source/WebCore/page/scrolling/ScrollingStateFrameHostingNode.h: * Source/WebCore/page/scrolling/ScrollingStateNode.cpp: (WebCore::ScrollingStateNode::ScrollingStateNode): * Source/WebCore/page/scrolling/ScrollingStateNode.h: * Source/WebKit/Scripts/generate-serializers.py: (SerializedType.has_optional_tuple_bits): (check_type_members): (encode_type): (decode_type): (generate_one_impl): (generate_serialized_type_info): (encode_optional_tuple): Deleted. (decode_optional_tuple): Deleted. * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.cpp: (IPC::ArgumentCoder<Namespace::Subnamespace::StructName>::encode): (IPC::ArgumentCoder<Namespace::OtherClass>::encode): (IPC::ArgumentCoder<Namespace::ReturnRefClass>::encode): (IPC::ArgumentCoder<Namespace::EmptyConstructorStruct>::encode): (IPC::ArgumentCoder<Namespace::EmptyConstructorWithIf>::encode): (IPC::ArgumentCoder<WithoutNamespace>::encode): (IPC::ArgumentCoder<WithoutNamespaceWithAttributes>::encode): (IPC::ArgumentCoder<WebCore::InheritsFrom>::encode): (IPC::ArgumentCoder<WebCore::InheritanceGrandchild>::encode): (IPC::ArgumentCoder<WTF::Seconds>::encode): (IPC::ArgumentCoder<WTF::CreateUsingClass>::encode): (IPC::ArgumentCoder<WebCore::FloatBoxExtent>::encode): (IPC::ArgumentCoder<SoftLinkedMember>::encode): (IPC::ArgumentCoder<Namespace::ConditionalCommonClass>::encode): (IPC::ArgumentCoder<Namespace::CommonClass>::encode): (IPC::ArgumentCoder<Namespace::AnotherCommonClass>::encode): (IPC::ArgumentCoder<WebCore::MoveOnlyDerivedClass>::encode): (IPC::ArgumentCoder<WebKit::LayerProperties>::encode): (IPC::ArgumentCoder<WebKit::LayerProperties>::decode): (IPC::ArgumentCoder<WebKit::TemplateTest<WebKit::Fabulous>>::encode): (IPC::ArgumentCoder<WebKit::TemplateTest<WebCore::Amazing>>::encode): (IPC::ArgumentCoder<WebKit::TemplateTest<JSC::Incredible>>::encode): (IPC::ArgumentCoder<WebKit::TemplateTest<Testing::StorageSize>>::encode): (IPC::ArgumentCoder<WebCore::ScrollingStateFrameHostingNode>::encode): (IPC::ArgumentCoder<WebCore::ScrollingStateFrameHostingNode>::decode): (IPC::ArgumentCoder<WebCore::ScrollingStateFrameHostingNodeWithStuffAfterTuple>::encode): (IPC::ArgumentCoder<WebCore::ScrollingStateFrameHostingNodeWithStuffAfterTuple>::decode): * Source/WebKit/Scripts/webkit/tests/GeneratedSerializers.h: * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: (WebKit::allSerializedTypes): * Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in: * Source/WebKit/Scripts/webkit/tests/WebKitPlatformGeneratedSerializers.cpp: (IPC::ArgumentCoder<WebKit::PlatformClass>::encode): * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerTree.serialization.in: * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp: (ArgumentCoder<WebCore::ScrollingStateFrameHostingNode>::encode): Deleted. (ArgumentCoder<WebCore::ScrollingStateFrameHostingNode>::decode): Deleted. * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.serialization.in: Canonical link: https://commits.webkit.org/269811@main

webkit-commit-queue · 2023-10-26T14:29:41Z

Committed 269811@main (887ac88): https://commits.webkit.org/269811@main

Reviewed commits have been landed. Closing PR #19580 and removing active labels.

achristensen07 requested a review from cdumez as a code owner October 26, 2023 03:40

achristensen07 self-assigned this Oct 26, 2023

achristensen07 added the WebKit Misc. For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore). label Oct 26, 2023

beidson approved these changes Oct 26, 2023

View reviewed changes

achristensen07 force-pushed the eng/Generate-serialization-for-ScrollingStateFrameHostingNode branch from 642ea5d to c797d7e Compare October 26, 2023 05:06

achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 26, 2023

webkit-commit-queue force-pushed the eng/Generate-serialization-for-ScrollingStateFrameHostingNode branch from c797d7e to 887ac88 Compare October 26, 2023 14:29

webkit-commit-queue merged commit 887ac88 into WebKit:main Oct 26, 2023

webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 26, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Generate serialization for ScrollingStateFrameHostingNode #19580

Generate serialization for ScrollingStateFrameHostingNode #19580

achristensen07 commented Oct 26, 2023 •

edited by webkit-early-warning-system

Loading

webkit-early-warning-system commented Oct 26, 2023 •

edited

Loading

beidson left a comment

beidson Oct 26, 2023

webkit-early-warning-system commented Oct 26, 2023 •

edited

Loading

webkit-commit-queue commented Oct 26, 2023

Generate serialization for ScrollingStateFrameHostingNode #19580

Generate serialization for ScrollingStateFrameHostingNode #19580

Conversation

achristensen07 commented Oct 26, 2023 • edited by webkit-early-warning-system Loading

887ac88

webkit-early-warning-system commented Oct 26, 2023 • edited Loading

beidson left a comment

Choose a reason for hiding this comment

beidson Oct 26, 2023

Choose a reason for hiding this comment

webkit-early-warning-system commented Oct 26, 2023 • edited Loading

webkit-commit-queue commented Oct 26, 2023

achristensen07 commented Oct 26, 2023 •

edited by webkit-early-warning-system

Loading

`887ac88`

webkit-early-warning-system commented Oct 26, 2023 •

edited

Loading

webkit-early-warning-system commented Oct 26, 2023 •

edited

Loading