Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused function from SQLitedatabase #1964

Merged
merged 1 commit into from Jul 1, 2022
Merged

Remove unused function from SQLitedatabase #1964

merged 1 commit into from Jul 1, 2022

Conversation

RupinMittal
Copy link
Contributor

@RupinMittal RupinMittal commented Jun 30, 2022 •
edited by webkit-commit-queue

6fe0158

Remove unused function from SQLitedatabase
https://bugs.webkit.org/show_bug.cgi?id=242205

Reviewed by Geoffrey Garen.

The function removeCollationFunction is not used anywhere.

* Source/WebCore/platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::removeCollationFunction): Deleted.
* Source/WebCore/platform/sql/SQLiteDatabase.h:

Canonical link: https://commits.webkit.org/252065@main

geoffreygaren
geoffreygaren approved these changes Jun 30, 2022
View reviewed changes
Copy link
Contributor

@geoffreygaren geoffreygaren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label Jun 30, 2022
@szewai szewai self-requested a review July 1, 2022 16:11
@RupinMittal RupinMittal changed the title Drop unused functions in SQLiteDatabase Remove unused function from SQLitedatabase Jul 1, 2022
@darinadler darinadler added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jul 1, 2022
@RupinMittal @darinadler
Remove unused function from SQLitedatabase
6fe0158 
https://bugs.webkit.org/show_bug.cgi?id=242205

Reviewed by Geoffrey Garen.

The function removeCollationFunction is not used anywhere.

* Source/WebCore/platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::removeCollationFunction): Deleted.
* Source/WebCore/platform/sql/SQLiteDatabase.h:

Canonical link: https://commits.webkit.org/252065@main
@webkit-commit-queue
Copy link
Collaborator

Committed 252065@main (6fe0158): https://commits.webkit.org/252065@main

Reviewed commits have been landed. Closing PR #1964 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 6fe0158 into WebKit:main Jul 1, 2022
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreygaren geoffreygaren geoffreygaren approved these changes

@szewai szewai Awaiting requested review from szewai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@RupinMittal @webkit-commit-queue @geoffreygaren @darinadler @webkit-early-warning-system