[import-w3c-tests] Explicitly list all directories we're not importing as skip #19642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsnedders
added
the
Tools / Tests
|
(This builds on top of #19442, still in review.) |
|
EWS run on previous version of this PR (hash 5781a96)
|
|
Not sure explicit-skip is the best name. |
|
Agree with @nt1m... the name could be improved but I don't have a better suggestion than what Tim proposed. |
gsnedders
force-pushed
the
import-expectations-explicit-skip
branch
from
5781a96
to
163e0e3
Compare
|
EWS run on previous version of this PR (hash 163e0e3) |
gsnedders
force-pushed
the
import-expectations-explicit-skip
branch
from
163e0e3
to
70ff1a4
Compare
|
EWS run on previous version of this PR (hash 70ff1a4) |
gsnedders
force-pushed
the
import-expectations-explicit-skip
branch
from
70ff1a4
to
4abc16a
Compare
|
EWS run on previous version of this PR (hash 4abc16a) |
gsnedders
force-pushed
the
import-expectations-explicit-skip
branch
from
4abc16a
to
5b14200
Compare
|
EWS run on previous version of this PR (hash 5b14200) |
JonWBedard
approved these changes
Dec 15, 2023
gsnedders
force-pushed
the
import-expectations-explicit-skip
branch
from
5b14200
to
5973c45
Compare
|
EWS run on current version of this PR (hash 5973c45)
|
gsnedders
added
unsafe-merge-queue
…g as skip https://bugs.webkit.org/show_bug.cgi?id=214006 Reviewed by Jonathan Bedard. Add a new value to import-expectations.json: "skip-new-directories". "skip-new-directories" is mostly treated the same as "skip" (i.e., everything under it is skipped, unless marked as "import"). However, unlike "skip", child files are imported, and child directories are added to import-expectations.json as "skip" (thus the name). We apply this to both "web-platform-tests" and "web-platform-tests/css", to avoid importing new test suites for (presumably new) specifications. By doing this, as opposed to applying "skip" directly to those directories, we gain visibility to new test suites being added, as these now cause a "skip" line to be added when doing a full import. * LayoutTests/imported/w3c/resources/import-expectations.json: * Tools/Scripts/webkitpy/style/checkers/jsonchecker.py: (JSONImportExpectationsChecker.check): * Tools/Scripts/webkitpy/w3c/test_downloader.py: (TestDownloader.__init__): (TestDownloader._init_paths_from_expectations): (TestDownloader.update_import_expectations): * Tools/Scripts/webkitpy/w3c/test_importer.py: (TestImporter.__init__): (TestImporter.do_import): (TestImporter.should_skip_path): Canonical link: https://commits.webkit.org/272109@main
webkit-commit-queue
force-pushed
the
import-expectations-explicit-skip
branch
from
5973c45
to
e5fd5e0
Compare
|
Committed 272109@main (e5fd5e0): https://commits.webkit.org/272109@main Reviewed commits have been landed. Closing PR #19642 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e5fd5e0
5973c45
🧪 style🛠 ios🛠 mac🛠 wpe🛠 wincairo🧪 bindings🛠 ios-sim🛠 mac-AS-debug🧪 wpe-wk2🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 api-wpe🧪 webkitpy🧪 ios-wk2-wpt🧪 mac-wk1🛠 gtk🧪 api-ios🧪 mac-wk2🧪 gtk-wk2🛠 tv🧪 mac-AS-debug-wk2🧪 api-gtk🛠 tv-sim🧪 mac-wk2-stress🛠 watch🛠 🧪 unsafe-merge🛠 watch-sim