Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebGPU] GPUDevice::createComputePipeline does not handle missing optional layout field #19644

Merged
merged 1 commit into from
Oct 30, 2023
Merged

[WebGPU] GPUDevice::createComputePipeline does not handle missing optional layout field #19644

merged 1 commit into from
Oct 30, 2023

Conversation

mwyrzykowski
Copy link
Contributor

@mwyrzykowski mwyrzykowski commented Oct 27, 2023 •
edited by webkit-early-warning-system
Loading

693c11a

[WebGPU] GPUDevice::createComputePipeline does not handle missing optional layout field
https://bugs.webkit.org/show_bug.cgi?id=263784
<radar://117589263>

Reviewed by Tadeu Zagallo.

The field is required according to the specification.

* Source/WebCore/Modules/WebGPU/GPUPipelineDescriptorBase.idl:

Canonical link: https://commits.webkit.org/269953@main

ddb923f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski self-assigned this Oct 27, 2023
@mwyrzykowski mwyrzykowski added the WebGPU For bugs in WebGPU label Oct 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 27, 2023 •
edited
Loading

EWS run on current version of this PR (hash ddb923f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@mwyrzykowski mwyrzykowski added the merge-queue Applied to send a pull request to merge-queue label Oct 30, 2023
@mwyrzykowski
[WebGPU] GPUDevice::createComputePipeline does not handle missing opt…
693c11a 
…ional layout field

https://bugs.webkit.org/show_bug.cgi?id=263784
<radar://117589263>

Reviewed by Tadeu Zagallo.

The field is required according to the specification.

* Source/WebCore/Modules/WebGPU/GPUPipelineDescriptorBase.idl:

Canonical link: https://commits.webkit.org/269953@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/WebGPU-GPUDevicecreateComputePipeline-does-not-handle-missing-optional-layout-field branch from ddb923f to 693c11a Compare October 30, 2023 17:15
@webkit-commit-queue
Copy link
Collaborator

Committed 269953@main (693c11a): https://commits.webkit.org/269953@main

Reviewed commits have been landed. Closing PR #19644 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 693c11a into WebKit:main Oct 30, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadeuzagallo tadeuzagallo tadeuzagallo approved these changes

@djg djg Awaiting requested review from djg

Assignees

@mwyrzykowski mwyrzykowski

Labels
WebGPU For bugs in WebGPU
Projects
None yet
Milestone
No milestone
4 participants
@mwyrzykowski @webkit-early-warning-system @webkit-commit-queue @tadeuzagallo