Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'readyState_during_canplay.html' local copy in favor of WPT Test case #19659

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Remove 'readyState_during_canplay.html' local copy in favor of WPT Test case #19659

merged 1 commit into from
Oct 28, 2023

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Oct 27, 2023 •
edited by webkit-early-warning-system
Loading

ed96df0

Remove 'readyState_during_canplay.html' local copy in favor of WPT Test case

https://bugs.webkit.org/show_bug.cgi?id=134793

Reviewed by Eric Carlson.

This patch removes local copy of W3C test in favor of Web Platform Test.
I confirmed locally via running 'import-w3c-tests' that we have latest copy of test in tree.
Similarly, I removed 'mac-wk2' expectation since WPT indicates it as passing test.

* LayoutTests/media/W3C/video/readyState/readyState_during_canplay-expected.txt: Removed
* LayoutTests/media/W3C/video/readyState/readyState_during_canplay.html: Ditto
* LayoutTests/platform/mac-wk2/TestExpectations: Remove Test Expectation

Canonical link: https://commits.webkit.org/269894@main

f9e869f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 added the Media Bugs related to the HTML 5 Media elements. label Oct 27, 2023
@Ahmad-S792 Ahmad-S792 self-assigned this Oct 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 27, 2023 •
edited
Loading

EWS run on current version of this PR (hash f9e869f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 🧪 merge ✅ 🛠 watch
✅ 🛠 watch-sim

@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review October 28, 2023 08:41
@Ahmad-S792 Ahmad-S792 added the merge-queue Applied to send a pull request to merge-queue label Oct 28, 2023
@Ahmad-S792
Remove 'readyState_during_canplay.html' local copy in favor of WPT Te…
ed96df0 
…st case

https://bugs.webkit.org/show_bug.cgi?id=134793

Reviewed by Eric Carlson.

This patch removes local copy of W3C test in favor of Web Platform Test.
I confirmed locally via running 'import-w3c-tests' that we have latest copy of test in tree.
Similarly, I removed 'mac-wk2' expectation since WPT indicates it as passing test.

* LayoutTests/media/W3C/video/readyState/readyState_during_canplay-expected.txt: Removed
* LayoutTests/media/W3C/video/readyState/readyState_during_canplay.html: Ditto
* LayoutTests/platform/mac-wk2/TestExpectations: Remove Test Expectation

Canonical link: https://commits.webkit.org/269894@main
@webkit-commit-queue
Copy link
Collaborator

Committed 269894@main (ed96df0): https://commits.webkit.org/269894@main

Reviewed commits have been landed. Closing PR #19659 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ed96df0 into WebKit:main Oct 28, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Oct 28, 2023
@Ahmad-S792 Ahmad-S792 deleted the fix134793-test-fix branch December 30, 2023 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-carlson eric-carlson eric-carlson approved these changes

@jernoble jernoble Awaiting requested review from jernoble

Assignees

@Ahmad-S792 Ahmad-S792

Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
Milestone
No milestone
4 participants
@Ahmad-S792 @webkit-early-warning-system @webkit-commit-queue @eric-carlson