Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EWS] Add DEFAULT_BRANCH variable #197

Merged
merged 0 commits into from Mar 10, 2022
Merged

[EWS] Add DEFAULT_BRANCH variable #197

merged 0 commits into from Mar 10, 2022

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Mar 10, 2022 •
edited

c4d618e

[EWS] Add DEFAULT_BRANCH variable
https://bugs.webkit.org/show_bug.cgi?id=237693
<rdar://problem/90067276 >

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(ShowIdentifier.evaluateCommand):
(CheckOutPullRequest.run):
(CleanGitRepo.__init__):


Canonical link: https://commits.webkit.org/248274@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@291112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@JonWBedard JonWBedard self-assigned this Mar 10, 2022
@JonWBedard JonWBedard requested a review from aj062 March 10, 2022 01:16
aj062
aj062 approved these changes Mar 10, 2022
View reviewed changes
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@JonWBedard JonWBedard force-pushed the eng/EWS-Add-DEFAULT_BRANCH-variable branch from 5592f1f to 1c72acd Compare March 10, 2022 16:25
@JonWBedard JonWBedard closed this Mar 10, 2022
@JonWBedard JonWBedard force-pushed the eng/EWS-Add-DEFAULT_BRANCH-variable branch from 1c72acd to c4d618e Compare March 10, 2022 16:32
@JonWBedard JonWBedard merged commit c4d618e into WebKit:main Mar 10, 2022
@JonWBedard
Copy link
Member Author

Landed https://commits.webkit.org/248274@main (c4d618e)!

@JonWBedard JonWBedard deleted the eng/EWS-Add-DEFAULT_BRANCH-variable branch March 10, 2022 16:34
@JonWBedard JonWBedard added Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKit Nightly Build labels Mar 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj062 aj062 aj062 approved these changes

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
2 participants
@JonWBedard @aj062