Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused iExploder scripts #19724

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Remove unused iExploder scripts #19724

merged 1 commit into from
Oct 30, 2023

Conversation

danielpunkass
Copy link
Contributor

@danielpunkass danielpunkass commented Oct 30, 2023 •
edited by webkit-early-warning-system
Loading

f997f0d

Remove unused iExploder scripts
https://bugs.webkit.org/show_bug.cgi?id=263900

Reviewed by Alexey Proskuryakov.

Since the removal of iExploder from the repository a few years ago, these scripts have
only been cruft with no apparent value. Removing them will make the Scripts folder
ever-so-slightly more comprehensible.
* Tools/Scripts/run-iexploder-tests: Removed.
* Tools/Scripts/update-iexploder-cssproperties: Removed.

Canonical link: https://commits.webkit.org/269975@main

6321b9f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

@danielpunkass danielpunkass self-assigned this Oct 30, 2023
@danielpunkass danielpunkass added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Oct 30, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 30, 2023 •
edited
Loading

EWS run on previous version of this PR (hash fb112d7)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ⏳ 🛠 wpe ⏳ 🛠 wincairo
  🧪 bindings ⏳ 🛠 ios-sim ⏳ 🛠 mac-AS-debug ⏳ 🧪 wpe-wk2
  🧪 webkitperl ⏳ 🧪 ios-wk2   🧪 api-mac   🛠 gtk
⏳ 🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
⏳ 🛠 🧪 jsc ⏳ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
⏳ 🛠 🧪 jsc-arm64 ⏳ 🛠 tv ⏳ 🧪 mac-AS-debug-wk2 ⏳ 🛠 jsc-armv7
⏳ 🛠 tv-sim   🧪 mac-wk2-stress ⏳ 🧪 jsc-armv7-tests
⏳ 🛠 watch ⏳ 🛠 jsc-mips
⏳ 🛠 watch-sim ⏳ 🧪 jsc-mips-tests

@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Oct 30, 2023 •
edited
Loading

EWS run on current version of this PR (hash 6321b9f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🛠 gtk
✅ 🧪 ios-wk2-wpt ✅ 🧪 mac-wk1 ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk2 ❌ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge ✅ 🛠 watch-sim

aproskuryakov
aproskuryakov approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@aproskuryakov aproskuryakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aproskuryakov aproskuryakov added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 30, 2023
@danielpunkass @aproskuryakov
Remove unused iExploder scripts
f997f0d 
https://bugs.webkit.org/show_bug.cgi?id=263900

Reviewed by Alexey Proskuryakov.

Since the removal of iExploder from the repository a few years ago, these scripts have
only been cruft with no apparent value. Removing them will make the Scripts folder
ever-so-slightly more comprehensible.
* Tools/Scripts/run-iexploder-tests: Removed.
* Tools/Scripts/update-iexploder-cssproperties: Removed.

Canonical link: https://commits.webkit.org/269975@main
@webkit-commit-queue
Copy link
Collaborator

Committed 269975@main (f997f0d): https://commits.webkit.org/269975@main

Reviewed commits have been landed. Closing PR #19724 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit f997f0d into WebKit:main Oct 30, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aproskuryakov aproskuryakov aproskuryakov approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@danielpunkass danielpunkass

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@danielpunkass @webkit-early-warning-system @webkit-commit-queue @aproskuryakov