Repeated calls to scrollIntoView({ block: 'center' }) can cause jiggling (affects Spotify lyrics) #19794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smfr
added
the
Scrolling
|
EWS run on previous version of this PR (hash 0b86c3f)
|
aprotyas
approved these changes
Oct 31, 2023
hortont424
approved these changes
Oct 31, 2023
webkit-ews-buildbot
added
the
merging-blocked
smfr
force-pushed
the
eng/Repeated-calls-to-scrollIntoView-block-center--can-cause-jiggling-affects-Spotify-lyrics
branch
from
0b86c3f
to
39f0b22
Compare
|
EWS run on previous version of this PR (hash 39f0b22) |
webkit-ews-buildbot
added
the
merging-blocked
smfr
force-pushed
the
eng/Repeated-calls-to-scrollIntoView-block-center--can-cause-jiggling-affects-Spotify-lyrics
branch
from
39f0b22
to
f322b4a
Compare
|
EWS run on previous version of this PR (hash f322b4a)
|
webkit-ews-buildbot
added
the
merging-blocked
smfr
force-pushed
the
eng/Repeated-calls-to-scrollIntoView-block-center--can-cause-jiggling-affects-Spotify-lyrics
branch
from
f322b4a
to
5523685
Compare
|
EWS run on previous version of this PR (hash 5523685) |
webkit-ews-buildbot
added
the
merging-blocked
smfr
force-pushed
the
eng/Repeated-calls-to-scrollIntoView-block-center--can-cause-jiggling-affects-Spotify-lyrics
branch
2 times, most recently
from
f322b4a
to
31cc753
Compare
|
EWS run on current version of this PR (hash 31cc753) |
…ing (affects Spotify lyrics) https://bugs.webkit.org/show_bug.cgi?id=263995 rdar://117755250 Reviewed by Tim Horton. Computation of the destination scroll position for `scrollIntoView({ block: 'center' })` involves a divide by 2, which gives a fractional result for some scroller sizes. This causes the computed scroll position to alternate between two values 1px apart when called repeatedly, since our scroll positions are integral. Fix by ceiling the target y value in the `ScrollAlignment::Behavior::AlignCenter` case in `ScrollableArea::getRectToExposeForScrollIntoView()`. * LayoutTests/TestExpectations: * LayoutTests/fast/scrolling/scroll-into-view-block-center-expected.txt: Added. * LayoutTests/fast/scrolling/scroll-into-view-block-center.html: Added. * Source/WebCore/platform/ScrollableArea.cpp: (WebCore::ScrollableArea::getRectToExposeForScrollIntoView const): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: Canonical link: https://commits.webkit.org/270160@main
webkit-commit-queue
force-pushed
the
eng/Repeated-calls-to-scrollIntoView-block-center--can-cause-jiggling-affects-Spotify-lyrics
branch
from
31cc753
to
7688e6c
Compare
|
Committed 270160@main (7688e6c): https://commits.webkit.org/270160@main Reviewed commits have been landed. Closing PR #19794 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
smfr
deleted the
eng/Repeated-calls-to-scrollIntoView-block-center--can-cause-jiggling-affects-Spotify-lyrics
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7688e6c
Repeated calls to scrollIntoView({ block: 'center' }) can cause jiggling (affects Spotify lyrics) https://bugs.webkit.org/show_bug.cgi?id=263995 rdar://117755250 Reviewed by Tim Horton. Computation of the destination scroll position for `scrollIntoView({ block: 'center' })` involves a divide by 2, which gives a fractional result for some scroller sizes. This causes the computed scroll position to alternate between two values 1px apart when called repeatedly, since our scroll positions are integral. Fix by ceiling the target y value in the `ScrollAlignment::Behavior::AlignCenter` case in `ScrollableArea::getRectToExposeForScrollIntoView()`. * LayoutTests/TestExpectations: * LayoutTests/fast/scrolling/scroll-into-view-block-center-expected.txt: Added. * LayoutTests/fast/scrolling/scroll-into-view-block-center.html: Added. * Source/WebCore/platform/ScrollableArea.cpp: (WebCore::ScrollableArea::getRectToExposeForScrollIntoView const): * Source/WebCore/rendering/RenderLayerScrollableArea.cpp: Canonical link: https://commits.webkit.org/270160@main31cc753
🧪 wpe-wk2