[browserperfdash-benchmark] Fix error logging from server after 251530@main #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clopez
added
Tools / Tests
aperezdc
approved these changes
Jul 1, 2022
Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
Outdated
Show resolved
Hide resolved
Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
Outdated
Show resolved
Hide resolved
clopez
force-pushed
the
bug-242242
branch
2 times, most recently
from
c08c026
to
a9b5941
Compare
|
Thanks! |
…0@main https://bugs.webkit.org/show_bug.cgi?id=242242 Reviewed by Adrian Perez de Castro. After porting to Python3 on 251530@main (r295525) the script not longer logs in stderr the reply from the server when this replies with an error. It only logs a generic exception. This is caused because urllib.request.urlopen on Python3 always raises an exception when the http server reply is different from 200. This patch wraps the call to return the HTTPError object instead of raising the exception. This HTTPError object can be used later as an HTTPResponse one, so we can read the reply from the server and log it. * Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py: (BrowserPerfDashRunner): (BrowserPerfDashRunner._send_post_request_data): (BrowserPerfDashRunner._upload_result): Canonical link: https://commits.webkit.org/252040@main
webkit-early-warning-system
force-pushed
the
bug-242242
branch
from
a9b5941
to
c0299cc
Compare
|
Committed 252040@main (c0299cc): https://commits.webkit.org/252040@main Reviewed commits have been landed. Closing PR #1989 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c0299cc