Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --ignore-external-source-id option to display-sampling-profiler-output #19928

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add --ignore-external-source-id option to display-sampling-profiler-output #19928

merged 1 commit into from
Nov 3, 2023

Conversation

Constellation
Copy link
Member

@Constellation Constellation commented Nov 3, 2023 •
edited by webkit-early-warning-system
Loading

7ae51b2

Add --ignore-external-source-id option to display-sampling-profiler-output
https://bugs.webkit.org/show_bug.cgi?id=264131
rdar://117887932

Reviewed by Justin Michaud.

Add --ignore-external-source-id option, which corresponds to samplingProfilerIgnoreExternalSourceID in JSC option.
It ignores source ID when unifying samples.

* Tools/Scripts/display-sampling-profiler-output:

Canonical link: https://commits.webkit.org/270158@main

de824b6

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

@Constellation Constellation self-assigned this Nov 3, 2023
@Constellation Constellation added the JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues. label Nov 3, 2023
@webkit-early-warning-system
Copy link
Collaborator

webkit-early-warning-system commented Nov 3, 2023 •
edited
Loading

EWS run on current version of this PR (hash de824b6)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug   🧪 wpe-wk2
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🛠 gtk
  🧪 ios-wk2-wpt   🧪 mac-wk1   🧪 gtk-wk2
✅ 🧪 api-ios   🧪 mac-wk2   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-AS-debug-wk2
  🛠 tv-sim
✅ 🛠 watch
✅ 🛠 🧪 unsafe-merge   🛠 watch-sim

justinmichaud
justinmichaud approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@justinmichaud justinmichaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rs=me

@Constellation Constellation added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 3, 2023
@Constellation
Add --ignore-external-source-id option to display-sampling-profiler-o…
7ae51b2 
…utput

https://bugs.webkit.org/show_bug.cgi?id=264131
rdar://117887932

Reviewed by Justin Michaud.

Add --ignore-external-source-id option, which corresponds to samplingProfilerIgnoreExternalSourceID in JSC option.
It ignores source ID when unifying samples.

* Tools/Scripts/display-sampling-profiler-output:

Canonical link: https://commits.webkit.org/270158@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Add---ignore-external-source-id-option-to-display-sampling-profiler-output branch from de824b6 to 7ae51b2 Compare November 3, 2023 03:52
@webkit-commit-queue
Copy link
Collaborator

Committed 270158@main (7ae51b2): https://commits.webkit.org/270158@main

Reviewed commits have been landed. Closing PR #19928 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7ae51b2 into WebKit:main Nov 3, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinmichaud justinmichaud justinmichaud approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@Constellation Constellation

Labels
JavaScriptCore For bugs in JavaScriptCore, the JS engine used by WebKit, other than kxmlcore issues.
Projects
None yet
Milestone
No milestone
4 participants
@Constellation @webkit-early-warning-system @webkit-commit-queue @justinmichaud