[webkitscmpy] Only respect the latest review #20
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonWBedard
force-pushed
the
eng/respect-latest-review
branch
from
cca8fad
to
39001b2
Compare
|
Testing auto-closing |
1 similar comment
|
Testing auto-closing |
|
Testing auto-reopening |
|
Sorry for the churn here, was using this bug to prototype |
JonWBedard
force-pushed
the
eng/respect-latest-review
branch
from
39001b2
to
62f23f7
Compare
dewei-zhu
reviewed
Oct 29, 2021
JonWBedard
force-pushed
the
eng/respect-latest-review
branch
from
62f23f7
to
135b566
Compare
dewei-zhu
approved these changes
Nov 1, 2021
https://bugs.webkit.org/show_bug.cgi?id=231987 <rdar://problem/84434991> Reviewed by Dewei Zhu. GitHub will report the entire history of a review, we should only respect the latest review state. * Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto. * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/remote/git_hub.py: (GitHub.PRGenerator.reviewers): * Tools/Scripts/libraries/webkitscmpy/webkitscmpy/test/pull_request_unittest.py: (TestNetworkPullRequestGitHub.test_approved_edits):
JonWBedard
force-pushed
the
eng/respect-latest-review
branch
from
135b566
to
3bced9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3bced9d