Commits on Nov 8, 2023

1. window.open should be able to open a popup with the same domain as an… …

   … existing site-isolated iframe
   
   https://bugs.webkit.org/show_bug.cgi?id=264323
   rdar://118015550
   
   Reviewed by Pascoe.
   
   If we already have a RemotePageProxy communicating with a WebPage in the right process, use it instead
   of making a new one and getting confused about which one to use.  If we do this, we need to grant that
   process cookie access because it may have a new first party.
   
   In addition, WebFrame::documentLoaderDetached was sending WebPageProxy::DidDestroyNavigation which was
   destroying the navigation while it was continuing in another process, which caused assertions.  To fix
   this, don't send this message if the load is continuing in another process.
   
   * LayoutTests/http/tests/site-isolation/iframe-and-window-open-expected.txt: Added.
   * LayoutTests/http/tests/site-isolation/iframe-and-window-open.html: Added.
   * LayoutTests/http/tests/site-isolation/resources/post-message-to-opener.html: Added.
   * Source/WebKit/UIProcess/ProvisionalPageProxy.cpp:
   (WebKit::ProvisionalPageProxy::initializeWebPage):
   * Source/WebKit/UIProcess/ProvisionalPageProxy.h:
   (WebKit::ProvisionalPageProxy::needsCookieAccessAddedInNetworkProcess const):
   * Source/WebKit/UIProcess/WebPageProxy.cpp:
   (WebKit::WebPageProxy::continueNavigationInNewProcess):
   
   Canonical link: https://commits.webkit.org/270368@main

   

   achristensen07 committed Nov 8, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 8a0ed5b
   • Browse repository at this point

   Copy the full SHA

   8a0ed5b View commit details

   Browse the repository at this point in the history