Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with Chrome on SpeechRecognition policy handling #20106

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Nov 7, 2023

7d0464c

Align with Chrome on SpeechRecognition policy handling
https://bugs.webkit.org/show_bug.cgi?id=264338
rdar://117598690

Reviewed by Jean-Yves Avenard.

To improve interop, we apply microphone feature policy to SpeechRecognition.
Covered by newly added test.

* LayoutTests/http/tests/media/media-stream/resources/speechRecognition-iframe.html: Added.
* LayoutTests/http/tests/media/media-stream/speech-recognition-iframe-allow-attribute-expected.txt: Added.
* LayoutTests/http/tests/media/media-stream/speech-recognition-iframe-allow-attribute.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::startRecognition):

Canonical link: https://commits.webkit.org/270432@main

6cd376d

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  wincairo
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ›  gtk
  πŸ§ͺ ios-wk2-wpt βœ… πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk2 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch
βœ… πŸ›  watch-sim

@youennf youennf self-assigned this Nov 7, 2023
@youennf youennf added the Media Bugs related to the HTML 5 Media elements. label Nov 7, 2023
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Nov 7, 2023
@youennf youennf force-pushed the eng/Align-with-Chrome-on-SpeechRecognition-policy-handling branch from eed70c4 to 6cd376d Compare November 9, 2023 07:45
@youennf youennf added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Nov 9, 2023
https://bugs.webkit.org/show_bug.cgi?id=264338
rdar://117598690

Reviewed by Jean-Yves Avenard.

To improve interop, we apply microphone feature policy to SpeechRecognition.
Covered by newly added test.

* LayoutTests/http/tests/media/media-stream/resources/speechRecognition-iframe.html: Added.
* LayoutTests/http/tests/media/media-stream/speech-recognition-iframe-allow-attribute-expected.txt: Added.
* LayoutTests/http/tests/media/media-stream/speech-recognition-iframe-allow-attribute.html: Added.
* LayoutTests/platform/glib/TestExpectations:
* Source/WebCore/Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::startRecognition):

Canonical link: https://commits.webkit.org/270432@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Align-with-Chrome-on-SpeechRecognition-policy-handling branch from 6cd376d to 7d0464c Compare November 9, 2023 08:58
@webkit-commit-queue
Copy link
Collaborator

Committed 270432@main (7d0464c): https://commits.webkit.org/270432@main

Reviewed commits have been landed. Closing PR #20106 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7d0464c into WebKit:main Nov 9, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
5 participants