[JSC] Disallow freezing only when allowing GC #20118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on current version of this PR (hash 19833cc) |
Constellation
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=264353 rdar://118069302 Reviewed by Justin Michaud. It turned out that DFG clobberize does freeze, and it is used for DFG dump. But we do not run it while running B3 of course, so this patch disallows freezing only when we are allowing GC for B3. * Source/JavaScriptCore/ftl/FTLCompile.cpp: (JSC::FTL::compile): Canonical link: https://commits.webkit.org/270341@main
webkit-commit-queue
force-pushed
the
eng/JSC-Disallow-freezing-only-when-allowing-GC
branch
from
19833cc
to
c181ce5
Compare
|
Committed 270341@main (c181ce5): https://commits.webkit.org/270341@main Reviewed commits have been landed. Closing PR #20118 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c181ce5
19833cc
🛠 wincairo🧪 wpe-wk2🧪 api-mac🧪 ios-wk2-wpt🧪 mac-wk1🧪 gtk-wk2🛠 🧪 jsc🧪 api-ios🧪 mac-wk2🧪 api-gtk🛠 tv🧪 mac-AS-debug-wk2🛠 tv-sim🧪 jsc-armv7-tests🛠 watch-sim